Skip to content

Lower arith.maximuf to maxf #158136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Lower arith.maximuf to maxf #158136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ae7cf2
lower arith.maximuf
Jaddyen Sep 11, 2025
721eb3c
Merge branch 'main' into maxf
Jaddyen Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions mlir/lib/Conversion/ArithToEmitC/ArithToEmitC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,25 @@ class NegFOpConversion : public OpConversionPattern<arith::NegFOp> {
}
};

class MaximumFOpLowering : public OpConversionPattern<arith::MaximumFOp> {
public:
using OpConversionPattern::OpConversionPattern;

LogicalResult
matchAndRewrite(arith::MaximumFOp op, OpAdaptor adaptor,
ConversionPatternRewriter &rewriter) const override {
Location loc = op.getLoc();

auto newOp = emitc::CallOpaqueOp::create(
rewriter, loc, op.getType(), rewriter.getStringAttr("fmax"),
ValueRange{adaptor.getLhs(), adaptor.getRhs()});

rewriter.replaceOp(op, newOp);

return success();
}
};

template <typename ArithOp, bool castToUnsigned>
class CastConversion : public OpConversionPattern<ArithOp> {
public:
Expand Down
Loading