Skip to content

Conversation

matthias-springer
Copy link
Member

Fix build after #156825.

Fix build after #156825.
@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Sep 12, 2025
@matthias-springer matthias-springer changed the title [mlir] Fix build [mlir][IR] Fix build error with gcc-7 Sep 12, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 12, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-core

Author: Matthias Springer (matthias-springer)

Changes

Fix build after #156825.


Full diff: https://github.com/llvm/llvm-project/pull/158305.diff

1 Files Affected:

  • (modified) mlir/lib/IR/Remarks.cpp (+1-1)
diff --git a/mlir/lib/IR/Remarks.cpp b/mlir/lib/IR/Remarks.cpp
index 29088bd360e23..a55f61aff77bb 100644
--- a/mlir/lib/IR/Remarks.cpp
+++ b/mlir/lib/IR/Remarks.cpp
@@ -284,7 +284,7 @@ buildFilter(const mlir::remark::RemarkCategories &cats,
   if (!rx.isValid(err))
     return std::nullopt;
 
-  return rx;
+  return std::make_optional<llvm::Regex>(std::move(rx));
 }
 
 RemarkEngine::RemarkEngine(bool printAsEmitRemarks,

@matthias-springer matthias-springer merged commit b2521ae into main Sep 12, 2025
11 of 12 checks passed
@matthias-springer matthias-springer deleted the users/matthias-springer/fix_build_12 branch September 12, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:core MLIR Core Infrastructure mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants