Skip to content

[scudo] Cap the PendingPushedBytesDelta [DO NOT MERGE] #158339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[scudo] Cap the PendingPushedBytesDelta [DO NOT MERGE] #158339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions compiler-rt/lib/scudo/standalone/primary64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1561,6 +1561,13 @@ bool SizeClassAllocator64<Config>::hasChanceToReleasePages(
if (DiffSinceLastReleaseNs < 2 * IntervalNs)
return false;
} else if (DiffSinceLastReleaseNs < IntervalNs) {
// `TryReleaseThreshold` is capped by (1UL << GroupSizeLog) / 2). If
// RegionPushedBytesDelta grows twice of the threshold, it implies some
// huge deallocations happening so we'd better still try to release some
// pages. Note that this is likely happened with large blocks.
if (RegionPushedBytesDelta > (1ULL << GroupSizeLog))
return true;

// In this case, we are over the threshold but we just did some page
// release in the same release interval. This is a hint that we may want
// a higher threshold so that we can release more memory at once.
Expand Down