-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[compiler-rt] Remove enable_execute_stack support on arm64 Darwin #158386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler-rt] Remove enable_execute_stack support on arm64 Darwin #158386
Conversation
`enable_execute_stack` is not supported on arm64 Darwin because: - It calls mprotect with `PROT_WRITE | PROT_EXEC`, which is rejected on this platform. - It assumes a fixed 4K page size, which is not guaranteed. This change disables building `enable_execute_stack` on arm64 Darwin and fixes the failing test: `compiler-rt/test/builtins/Unit/enable_execute_stack_test.c`. rdar://159705691
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it was just the page size, that could be adjusted. Android will need 16k pages as well.
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/206/builds/6203 Here is the relevant piece of the build log for the reference
|
Apologies for the buildbot noise, please ignore this error. |
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/12879 Here is the relevant piece of the build log for the reference
|
enable_execute_stack
is not supported on arm64 Darwin because:PROT_WRITE | PROT_EXEC
, which is rejected on this platform.This change disables building
enable_execute_stack
on arm64 Darwin and fixes the failing test:compiler-rt/test/builtins/Unit/enable_execute_stack_test.c
.rdar://159705691