Skip to content

[ADT] Reduce boilerplate in DenseSet (NFC) #158456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2025
Merged

[ADT] Reduce boilerplate in DenseSet (NFC) #158456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd0ccbb
[ADT] Reduce boilerplate in DenseSet (NFC)
kazutakahirata Sep 7, 2025
ba7eb1d
Address a comment.
kazutakahirata Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 16 additions & 20 deletions llvm/include/llvm/ADT/DenseSet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,20 +250,24 @@ bool operator!=(const DenseSetImpl<ValueT, MapTy, ValueInfoT> &LHS,
return !(LHS == RHS);
}

template <typename ValueT, typename ValueInfoT>
using DenseSet = DenseSetImpl<
ValueT, DenseMap<ValueT, DenseSetEmpty, ValueInfoT, DenseSetPair<ValueT>>,
ValueInfoT>;

template <typename ValueT, unsigned InlineBuckets, typename ValueInfoT>
using SmallDenseSet =
DenseSetImpl<ValueT,
SmallDenseMap<ValueT, DenseSetEmpty, InlineBuckets, ValueInfoT,
DenseSetPair<ValueT>>,
ValueInfoT>;

} // end namespace detail

/// Implements a dense probed hash-table based set.
template <typename ValueT, typename ValueInfoT = DenseMapInfo<ValueT>>
class DenseSet : public detail::DenseSetImpl<
ValueT,
DenseMap<ValueT, detail::DenseSetEmpty, ValueInfoT,
detail::DenseSetPair<ValueT>>,
ValueInfoT> {
using BaseT =
detail::DenseSetImpl<ValueT,
DenseMap<ValueT, detail::DenseSetEmpty, ValueInfoT,
detail::DenseSetPair<ValueT>>,
ValueInfoT>;
class DenseSet : public detail::DenseSet<ValueT, ValueInfoT> {
using BaseT = detail::DenseSet<ValueT, ValueInfoT>;

public:
using BaseT::BaseT;
Expand All @@ -274,16 +278,8 @@ class DenseSet : public detail::DenseSetImpl<
template <typename ValueT, unsigned InlineBuckets = 4,
typename ValueInfoT = DenseMapInfo<ValueT>>
class SmallDenseSet
: public detail::DenseSetImpl<
ValueT,
SmallDenseMap<ValueT, detail::DenseSetEmpty, InlineBuckets,
ValueInfoT, detail::DenseSetPair<ValueT>>,
ValueInfoT> {
using BaseT = detail::DenseSetImpl<
ValueT,
SmallDenseMap<ValueT, detail::DenseSetEmpty, InlineBuckets, ValueInfoT,
detail::DenseSetPair<ValueT>>,
ValueInfoT>;
: public detail::SmallDenseSet<ValueT, InlineBuckets, ValueInfoT> {
using BaseT = detail::SmallDenseSet<ValueT, InlineBuckets, ValueInfoT>;

public:
using BaseT::BaseT;
Expand Down
Loading