Skip to content

Conversation

zmodem
Copy link
Collaborator

@zmodem zmodem commented Sep 15, 2025

So that it gets included in LLVM_INSTALL_TOOLCHAIN_ONLY builds, such as when building the Windows installer.

Fixes #149664

So that it gets included in LLVM_INSTALL_TOOLCHAIN_ONLY builds, such as
when building the Windows installer.

Fixes llvm#149664
@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Sep 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 15, 2025

@llvm/pr-subscribers-platform-windows

Author: Hans Wennborg (zmodem)

Changes

So that it gets included in LLVM_INSTALL_TOOLCHAIN_ONLY builds, such as when building the Windows installer.

Fixes #149664


Full diff: https://github.com/llvm/llvm-project/pull/158582.diff

1 Files Affected:

  • (modified) llvm/cmake/modules/AddLLVM.cmake (+1)
diff --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake
index c98e78da97b39..80e59a4df2433 100644
--- a/llvm/cmake/modules/AddLLVM.cmake
+++ b/llvm/cmake/modules/AddLLVM.cmake
@@ -1442,6 +1442,7 @@ if(NOT LLVM_TOOLCHAIN_TOOLS)
     llvm-lib
     llvm-mca
     llvm-ml
+    llvm-ml64
     llvm-nm
     llvm-objcopy
     llvm-objdump

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ericastor ericastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this oversight!

@ericastor ericastor merged commit 228e240 into llvm:main Sep 15, 2025
12 of 13 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Sep 15, 2025

LLVM Buildbot has detected a new failure on builder clang-ppc64le-linux-multistage running on ppc64le-clang-multistage-test while building llvm at step 5 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/12877

Here is the relevant piece of the build log for the reference
Step 5 (ninja check 1) failure: 1200 seconds without output running [b'ninja', b'check-all', b'check-runtimes'], attempting to kill
...
[79/85] Generating POWERPC64LELinuxConfig/Asan-powerpc64le-inline-Noinst-Test
[80/85] Generating ASAN_INST_TEST_OBJECTS.gtest-all.cc.powerpc64le-calls.o
[81/85] Generating POWERPC64LELinuxDynamicConfig/Asan-powerpc64le-calls-Dynamic-Test
[82/85] Generating POWERPC64LELinuxConfig/Asan-powerpc64le-calls-Test
[83/85] Generating ASAN_INST_TEST_OBJECTS.gtest-all.cc.powerpc64le-inline.o
[84/85] Generating POWERPC64LELinuxDynamicConfig/Asan-powerpc64le-inline-Dynamic-Test
[85/85] Generating POWERPC64LELinuxConfig/Asan-powerpc64le-inline-Test
[1032/1256] No install step for 'runtimes'
[1033/1256] cd /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/runtimes/runtimes-bins && /home/buildbots/llvm-external-buildbots/cmake-3.31.2/bin/cmake --build /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/runtimes/runtimes-bins/ --target check-runtimes --config Release
[0/1] Running runtimes regression tests
command timed out: 1200 seconds without output running [b'ninja', b'check-all', b'check-runtimes'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1494.825636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular platform:windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm-ml with "-m64" command line flag by default for 64 bit package
6 participants