Skip to content

[IntrinsicEmitter] Make AttributesMap bound inclusive #158714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

[IntrinsicEmitter] Make AttributesMap bound inclusive #158714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/test/TableGen/intrinsic-attrs.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ def int_deref_ptr_ret : Intrinsic<[llvm_ptr_ty], [], [Dereferenceable<RetIndex,
// CHECK-NEXT: });

// CHECK: static constexpr uint16_t IntrinsicsToAttributesMap[] = {
// CHECK: 0 << 2 | 0, // llvm.deref.ptr.ret
// CHECK: 1 << 2 | 1, // llvm.random.gen
// CHECK: 0 << 1 | 0, // llvm.deref.ptr.ret
// CHECK: 1 << 1 | 1, // llvm.random.gen
// CHECK: }; // IntrinsicsToAttributesMap

// CHECK: static constexpr ArgNoAttrIDPair ArgAttrIdTable[] = {
Expand Down
4 changes: 2 additions & 2 deletions llvm/utils/TableGen/Basic/IntrinsicEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,10 +629,10 @@ static constexpr uint16_t IntrinsicsToAttributesMap[] = {)";
UniqAttributes.try_emplace(&Int, ID);
}

const uint8_t UniqAttributesBitSize = Log2_32_Ceil(UniqAttributes.size() + 1);
const uint8_t UniqAttributesBitSize = Log2_32_Ceil(UniqAttributes.size());
// Note, ID `-1` is used to indicate no function attributes.
const uint8_t UniqFnAttributesBitSize =
Log2_32_Ceil(UniqFnAttributes.size() + 2);
Log2_32_Ceil(UniqFnAttributes.size() + 1);
const uint16_t NoFunctionAttrsID =
maskTrailingOnes<uint16_t>(UniqFnAttributesBitSize);
if (UniqAttributesBitSize + UniqFnAttributesBitSize > 16)
Expand Down