[LLDB] [Tests] Downgrade -Wincompatible-pointer-types to a warning in some tests #158756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: None (Sirraide) ChangesThese no longer compile because the warning now defaults to an error after #157364, so downgrade the error to a warning for now; I’m not familiar enough with either LLDB or MacOS to fix these warnings properly (assuming they’re unintended). Full diff: https://github.com/llvm/llvm-project/pull/158756.diff 2 Files Affected:
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/Makefile b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/Makefile
index 8b322ff320bb0..5ef65e0c08451 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-objc/Makefile
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-objc/Makefile
@@ -1,6 +1,6 @@
OBJC_SOURCES := main.m
-CFLAGS_EXTRAS := -w
+CFLAGS_EXTRAS := -w -Wno-error=incompatible-pointer-types
diff --git a/lldb/test/API/macosx/ignore_exceptions/Makefile b/lldb/test/API/macosx/ignore_exceptions/Makefile
index 695335e068c0c..14ed92da5296b 100644
--- a/lldb/test/API/macosx/ignore_exceptions/Makefile
+++ b/lldb/test/API/macosx/ignore_exceptions/Makefile
@@ -1,4 +1,4 @@
C_SOURCES := main.c
-CFLAGS_EXTRAS := -std=c99
+CFLAGS_EXTRAS := -std=c99 -Wno-error=incompatible-pointer-types
include Makefile.rules
|
medismailben
approved these changes
Sep 16, 2025
|
This fixed the issue. Thanks! https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/33239/ |
MrSidims
added a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 16, 2025
InvalidAtomicBuiltins.cl requires an update after llvm/llvm-project#158756 Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
kimsh02
pushed a commit
to kimsh02/llvm-project
that referenced
this pull request
Sep 19, 2025
… some tests (llvm#158756) These no longer compile because the warning now defaults to an error after llvm#157364, so downgrade the error to a warning for now; I’m not familiar enough with either LLDB or MacOS to fix these warnings properly (assuming they’re unintended).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These no longer compile because the warning now defaults to an error after #157364, so downgrade the error to a warning for now; I’m not familiar enough with either LLDB or MacOS to fix these warnings properly (assuming they’re unintended).