Skip to content

[AST] Simplify TypeIsArrayType (NFC) #158784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

[AST] Simplify TypeIsArrayType (NFC) #158784

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ad0d63
[AST] Use std::bool_constant instead of std::integral_constant (NFC)
kazutakahirata Sep 15, 2025
07dfa5b
Address a comment.
kazutakahirata Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions clang/include/clang/AST/TypeBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9092,10 +9092,7 @@ inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &PD,

// Helper class template that is used by Type::getAs to ensure that one does
// not try to look through a qualified type to get to an array type.
template <typename T>
using TypeIsArrayType =
std::integral_constant<bool, std::is_same<T, ArrayType>::value ||
std::is_base_of<ArrayType, T>::value>;
template <typename T> using TypeIsArrayType = std::is_base_of<ArrayType, T>;

// Member-template getAs<specific type>'.
template <typename T> const T *Type::getAs() const {
Expand Down