Add executed MC/DC TestVectors to llvm-cov export
#159119
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@evodius96 here we go |
|
@EugeneZelenko Hi! Can you please help to assign @evodius96 here as a reviewer? |
|
Thank you, @kuzmich321. Is it your intention to take over the contribution from @Swatinem? |
Thanks! Yes, it is. We agreed on that |
|
@evodius96 Yes, I think I need help with the merging. I believe I don't have a write access. Thanks a lot! |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
OK thanks. It looks like the code formatter is complaining. Can you run clang-format and clean it up? |
kuzmich321
force-pushed
the
mcdc-export-testvectors-v2
branch
from
31583a8 to
f721125
Compare
|
@kuzmich321 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
It adds a new JSON array with the list of test vectors to the end of the mcdc_records. I also bumped the json format version accordingly, which I believe wasn’t done properly in the past when new fields were added. This PR adds tests and comment docs for llvm#105511 --------- Co-authored-by: Arpad Borsos <swatinem@swatinem.de>
This PR adds tests and comment docs for #105511