[CAS] Disable OnDiskCAS build on Solaris #159122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6
cachemeifyoucan
deleted the
users/cachemeifyoucan/spr/cas-disable-ondiskcas-build-on-solaris
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/16137 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/16149 Here is the relevant piece of the build log for the reference |
cachemeifyoucan
added a commit
that referenced
this pull request
Sep 17, 2025
As a follow up to #159122, after figure out reason why CAS unit tests are failing on Solaris, update the CMake configuration to build ondisk CAS implementation. We now check the existance of `flock` before enabling the configuration. In the future, we can find ways to support OnDiskCAS on other platforms that do not have `flock`. This can techinically be done with a POSIX compilant file lock but that will put a restriction on the usage of CAS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnDiskCAS implementation receives error
No record locks availableon Solaris. Disable building on Solaris for now to fix buildbot failure.