[MLIR][Python] add not to MLIR_PYTHON_TEST_DEPENDS
#159124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
requested review from
ftynse,
stellaraccident and
rolfmorel
as code owners
|
@llvm/pr-subscribers-mlir Author: Maksim Levental (makslevental) Changeslit complains if these aren't found (even if they're not used by a test...) so make sure to include all of them in Full diff: https://github.com/llvm/llvm-project/pull/159124.diff 1 Files Affected:
diff --git a/mlir/test/python/CMakeLists.txt b/mlir/test/python/CMakeLists.txt
index d68f3ff82e883..e1e82ef367b1e 100644
--- a/mlir/test/python/CMakeLists.txt
+++ b/mlir/test/python/CMakeLists.txt
@@ -13,7 +13,7 @@ add_subdirectory(lib)
set(MLIR_PYTHON_TEST_DEPENDS MLIRPythonModules)
if(NOT MLIR_STANDALONE_BUILD)
- list(APPEND MLIR_PYTHON_TEST_DEPENDS FileCheck count)
+ list(APPEND MLIR_PYTHON_TEST_DEPENDS FileCheck count not)
endif()
add_lit_testsuite(check-mlir-python "Running the MLIR Python regression tests"
${CMAKE_CURRENT_BINARY_DIR}
|
makslevental
changed the title
not to MLIR_PYTHON_TEST_DEPENDS
kimsh02
pushed a commit
to kimsh02/llvm-project
that referenced
this pull request
Sep 19, 2025
[lit complains if these aren't found](https://github.com/llvm/llvm-project/blob/95fc948c0a07953ae9d0973854336e197e36d349/llvm/utils/lit/lit/llvm/config.py#L466-L482) (even if they're not used by a test...) so make sure to include all of them in `MLIR_PYTHON_TEST_DEPENDS`.
SeongjaeP
pushed a commit
to SeongjaeP/llvm-project
that referenced
this pull request
Sep 23, 2025
[lit complains if these aren't found](https://github.com/llvm/llvm-project/blob/95fc948c0a07953ae9d0973854336e197e36d349/llvm/utils/lit/lit/llvm/config.py#L466-L482) (even if they're not used by a test...) so make sure to include all of them in `MLIR_PYTHON_TEST_DEPENDS`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lit complains if these aren't found (even if they're not used by a test...) so make sure to include all of them in
MLIR_PYTHON_TEST_DEPENDS.