Skip to content

Conversation

sarnex
Copy link
Member

@sarnex sarnex commented Sep 16, 2025

Currently get this error

offload/plugins-nextgen/common/src/PluginInterface.cpp:859:63: error: member reference type 'StringRef' is not a pointer; did you mean to use '.'?

We pass the full image binary now so we can't really print anything useful here.

Seems introduced in #158748.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review September 16, 2025 18:23
@sarnex sarnex requested a review from jhuber6 September 16, 2025 18:23
@llvmbot
Copy link
Member

llvmbot commented Sep 16, 2025

@llvm/pr-subscribers-offload

Author: Nick Sarnie (sarnex)

Changes

Currently get this error

offload/plugins-nextgen/common/src/PluginInterface.cpp:859:63: error: member reference type 'StringRef' is not a pointer; did you mean to use '.'?

We pass the full image binary now so we can't really print anything useful here.

Seems introduced in #158748.


Full diff: https://github.com/llvm/llvm-project/pull/159144.diff

1 Files Affected:

  • (modified) offload/plugins-nextgen/common/src/PluginInterface.cpp (+1-1)
diff --git a/offload/plugins-nextgen/common/src/PluginInterface.cpp b/offload/plugins-nextgen/common/src/PluginInterface.cpp
index 4f83caf7a1187..684deb19b4eda 100644
--- a/offload/plugins-nextgen/common/src/PluginInterface.cpp
+++ b/offload/plugins-nextgen/common/src/PluginInterface.cpp
@@ -856,7 +856,7 @@ Error GenericDeviceTy::deinit(GenericPluginTy &Plugin) {
 }
 Expected<DeviceImageTy *> GenericDeviceTy::loadBinary(GenericPluginTy &Plugin,
                                                       StringRef InputTgtImage) {
-  DP("Load data from image " DPxMOD "\n", DPxPTR(InputTgtImage->ImageStart));
+  DP("Load data from image\n");
 
   std::unique_ptr<MemoryBuffer> Buffer;
   if (identify_magic(InputTgtImage) == file_magic::bitcode) {

@jhuber6
Copy link
Contributor

jhuber6 commented Sep 16, 2025

Surprised I didn't catch that since I did a debug build to fix a missing destructor, ah well.

Co-authored-by: Joseph Huber <huberjn@outlook.com>
@sarnex sarnex merged commit f74583f into llvm:main Sep 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants