Skip to content

[CAS] LLVM_ENABLE_ONDISK_CAS requires flock on UNIX #159207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

[CAS] LLVM_ENABLE_ONDISK_CAS requires flock on UNIX #159207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
900c71f
[𝘀𝗽𝗿] initial version
cachemeifyoucan Sep 16, 2025
9e27358
Fix a typo in comment
cachemeifyoucan Sep 16, 2025
fcf3442
Rebase to main
cachemeifyoucan Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions llvm/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,13 +879,6 @@ option (LLVM_ENABLE_OCAMLDOC "Build OCaml bindings documentation." ON)
option (LLVM_ENABLE_BINDINGS "Build bindings." ON)
option (LLVM_ENABLE_TELEMETRY "Enable the telemetry library. If set to OFF, library cannot be enabled after build (eg., at runtime)" ON)

set(LLVM_ENABLE_ONDISK_CAS_default ON)
if("${CMAKE_SYSTEM_NAME}" MATCHES SunOS)
# Build OnDiskCAS by default only on non-Solaris machines.
set(LLVM_ENABLE_ONDISK_CAS_default OFF)
endif()
option(LLVM_ENABLE_ONDISK_CAS "Build OnDiskCAS." ${LLVM_ENABLE_ONDISK_CAS_default})

set(LLVM_INSTALL_DOXYGEN_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/llvm/doxygen-html"
CACHE STRING "Doxygen-generated HTML documentation install directory")
set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/llvm/ocaml-html"
Expand Down
8 changes: 8 additions & 0 deletions llvm/cmake/modules/HandleLLVMOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,3 +1469,11 @@ if(LLVM_ENABLE_LLVM_LIBC)
message(WARNING "Unable to link against LLVM libc. LLVM will be built without linking against the LLVM libc overlay.")
endif()
endif()

check_symbol_exists(flock "sys/file.h" HAVE_FLOCK)
set(LLVM_ENABLE_ONDISK_CAS_default OFF)
if(HAVE_FLOCK OR LLVM_ON_WIN32)
# LLVM OnDisk CAS currently requires flock on Unix.
set(LLVM_ENABLE_ONDISK_CAS_default ON)
endif()
option(LLVM_ENABLE_ONDISK_CAS "Build OnDiskCAS." ${LLVM_ENABLE_ONDISK_CAS_default})