[BOLT] Don't check address past end of function for data/code marker annotation #159210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…marker annotation We want to annotate function with data and code markers whose addresses fall within the range of the function, so setting `CheckPastEnd` to false.
yozhu
requested review from
aaupov,
ayermolo,
maksfb,
paschalis-mpeis,
rafaelauler and
yota9
as code owners
|
@llvm/pr-subscribers-bolt Author: YongKang Zhu (yozhu) ChangesWe want to annotate function with data and code markers whose addresses fall within the range of the function, so setting Full diff: https://github.com/llvm/llvm-project/pull/159210.diff 1 Files Affected:
diff --git a/bolt/lib/Rewrite/RewriteInstance.cpp b/bolt/lib/Rewrite/RewriteInstance.cpp
index a6e4dbc9c192f..8b78c53aa99b3 100644
--- a/bolt/lib/Rewrite/RewriteInstance.cpp
+++ b/bolt/lib/Rewrite/RewriteInstance.cpp
@@ -1312,7 +1312,9 @@ void RewriteInstance::discoverFileObjects() {
// Annotate functions with code/data markers in AArch64
for (auto &[Address, Type] : MarkerSymbols) {
- auto *BF = BC->getBinaryFunctionContainingAddress(Address, true, true);
+ auto *BF = BC->getBinaryFunctionContainingAddress(Address,
+ /*CheckPastEnd*/ false,
+ /*UseMaxSize*/ true);
if (!BF) {
// Stray marker
|
|
Thanks for the review, Maksim! |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…annotation (llvm#159210) We want to annotate function with data and code markers whose addresses fall within the range of the function, so setting `CheckPastEnd` to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to annotate function with data and code markers whose addresses fall within the range of the function, so setting
CheckPastEndto false.