[libc++] XFAIL regex tests that are currently failing on macOS #159260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philnik777
force-pushed
the
xfail_macos
branch
from
1f82e78 to
35e4c45
Compare
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Nikolas Klauser (philnik777) ChangesIt seems that an OS update changed the localization on macOS. This XFAILs the tests to make sure the CI is green again until the tests can be updated. Full diff: https://github.com/llvm/llvm-project/pull/159260.diff 9 Files Affected:
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
index 151c9160b0fee..8c2875de01c52 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/awk.locale.pass.cpp
@@ -20,6 +20,7 @@
// TODO(netbsd): incomplete support for locales
// XFAIL: target={{.*}}-linux-gnu{{.*}}, netbsd, freebsd
// XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
// REQUIRES: locale.cs_CZ.ISO8859-2
#include <regex>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
index 463d0fd3bd1eb..9002681547b8d 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/basic.locale.pass.cpp
@@ -24,6 +24,7 @@
// TODO: investigation needed
// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
// XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
index b83bfabfb96be..2e6f7fd285ae4 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/ecma.locale.pass.cpp
@@ -24,6 +24,7 @@
// TODO: investigation needed
// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
// XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
index 24c38e9f631c9..4948f68f3934c 100644
--- a/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.match/extended.locale.pass.cpp
@@ -24,6 +24,7 @@
// TODO: investigation needed
// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
// XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
index 3a0229ec3be2f..4c883a1cf380f 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/awk.locale.pass.cpp
@@ -24,6 +24,7 @@
// TODO: investigation needed
// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
// XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
index eba6b3383059a..7bf28a27ea604 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/basic.locale.pass.cpp
@@ -24,6 +24,7 @@
// TODO: investigation needed
// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
// XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
index 175a05a9ef7c4..64365932bfe72 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/ecma.locale.pass.cpp
@@ -24,6 +24,7 @@
// TODO: investigation needed
// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
// XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp b/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
index e7dbccd6f0ba4..22a98c601de5a 100644
--- a/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
+++ b/libcxx/test/std/re/re.alg/re.alg.search/extended.locale.pass.cpp
@@ -24,6 +24,7 @@
// TODO: investigation needed
// XFAIL: target={{.*}}-linux-gnu{{.*}}, freebsd
// XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
#include <regex>
#include <cassert>
diff --git a/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp b/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp
index 803d062693c33..50434832ddfff 100644
--- a/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp
+++ b/libcxx/test/std/re/re.traits/lookup_collatename.pass.cpp
@@ -25,6 +25,7 @@
// TODO: investigation needed
// XFAIL: target={{.*}}-linux-gnu{{.*}}
// XFAIL: target={{.*}}-amazon-linux{{.*}}
+// XFAIL: target={{.*}}-apple-{{.*}}
#include <regex>
#include <iterator>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that an OS update changed the localization on macOS. This XFAILs the tests to make sure the CI is green again until the tests can be updated.