Skip to content

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Sep 17, 2025

RISC-V has over a million bytes in the table.

RISC-V has over a million bytes in the table.
@llvmbot llvmbot added tablegen llvm:SelectionDAG SelectionDAGISel as well labels Sep 17, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 17, 2025

@llvm/pr-subscribers-llvm-selectiondag

@llvm/pr-subscribers-tablegen

Author: Craig Topper (topperc)

Changes

RISC-V has over a million bytes in the table.


Full diff: https://github.com/llvm/llvm-project/pull/159479.diff

1 Files Affected:

  • (modified) llvm/utils/TableGen/DAGISelMatcherEmitter.cpp (+1-1)
diff --git a/llvm/utils/TableGen/DAGISelMatcherEmitter.cpp b/llvm/utils/TableGen/DAGISelMatcherEmitter.cpp
index d3fba6a92357a..ee10500a7ff50 100644
--- a/llvm/utils/TableGen/DAGISelMatcherEmitter.cpp
+++ b/llvm/utils/TableGen/DAGISelMatcherEmitter.cpp
@@ -29,7 +29,7 @@
 using namespace llvm;
 
 enum {
-  IndexWidth = 6,
+  IndexWidth = 7,
   FullIndexWidth = IndexWidth + 4,
   HistOpcWidth = 40,
 };

Copy link
Contributor

@s-barannikov s-barannikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As a suggestion, I think the value could be computed from the table size. So that we don't print redundant spaces.

@topperc
Copy link
Collaborator Author

topperc commented Sep 17, 2025

LGTM

As a suggestion, I think the value could be computed from the table size. So that we don't print redundant spaces.

Yeah. The calculation in your decoder patch reminded I had been meaning to update the number. The comments in DAG aren't enabled by default so you only see any of this if you add the cmake flag or run tblgen manually.

@topperc topperc merged commit 658bb98 into llvm:main Sep 17, 2025
10 of 12 checks passed
@topperc topperc deleted the pr/indexwidth branch September 17, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:SelectionDAG SelectionDAGISel as well tablegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants