Skip to content

[libc][math] Update test/src/math/smoke/FmaTest.h to not rely on compiler runtime. #159503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

[libc][math] Update test/src/math/smoke/FmaTest.h to not rely on compiler runtime. #159503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b853a84
[libc][math] Update test/src/math/smoke/FmaTest.h to not rely on comp…
lntue Sep 18, 2025
876b8d9
Remove unused variable.
lntue Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions libc/test/src/math/smoke/FmaTest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,8 @@ class FmaTestTemplate : public LIBC_NAMESPACE::testing::FEnvSafeTest {
}

// Test overflow.
OutType z = out.max_normal;
InType in_z = LIBC_NAMESPACE::fputil::cast<InType>(out.max_normal);
EXPECT_FP_EQ_ALL_ROUNDING(OutType(0.75) * z,
EXPECT_FP_EQ_ALL_ROUNDING(func(InType(-0.25), in_z, in_z),
func(InType(1.75), in_z, -in_z));

// Exact cancellation.
Expand Down
38 changes: 18 additions & 20 deletions utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,21 +204,20 @@ math_test(
hdrs = ["FmaTest.h"],
)

# TODO: Reenable these tests once they pass at Google.
# math_test(
# name = "f16fma",
# hdrs = ["FmaTest.h"],
# )
#
# math_test(
# name = "f16fmaf",
# hdrs = ["FmaTest.h"],
# )
#
# math_test(
# name = "f16fmal",
# hdrs = ["FmaTest.h"],
# )
math_test(
name = "f16fma",
hdrs = ["FmaTest.h"],
)

math_test(
name = "f16fmaf",
hdrs = ["FmaTest.h"],
)

math_test(
name = "f16fmal",
hdrs = ["FmaTest.h"],
)

math_test(
name = "dmull",
Expand Down Expand Up @@ -477,11 +476,10 @@ math_test(

# TODO: Add fma, fmaf, fmal, fmaf128 tests.

# TODO: Reenable this test once it passes at Google.
# math_test(
# name = "fmaf16",
# hdrs = ["FmaTest.h"],
# )
math_test(
name = "fmaf16",
hdrs = ["FmaTest.h"],
)

math_test(
name = "fmax",
Expand Down
Loading