Skip to content

[llvm-mca] Round UP when formatting Reciprocal Throughput #159544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

[llvm-mca] Round UP when formatting Reciprocal Throughput #159544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/test/tools/llvm-mca/AArch64/Neoverse/V1-basic-instructions.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2688,7 +2688,7 @@ drps
# CHECK-NEXT: 1 1 0.25 movk x7, #0, lsl #32
# CHECK-NEXT: 1 1 0.25 movz x8, #0, lsl #48
# CHECK-NEXT: 1 1 0.25 movk x9, #0, lsl #48
# CHECK-NEXT: 1 1 0.12 U msr DAIFSet, #0
# CHECK-NEXT: 1 1 0.13 U msr DAIFSet, #0
# CHECK-NEXT: 1 1 0.25 adr x2, #1600
# CHECK-NEXT: 1 1 0.25 adrp x21, #6553600
# CHECK-NEXT: 1 1 0.25 adr x0, #262144
Expand Down
30 changes: 15 additions & 15 deletions llvm/test/tools/llvm-mca/AArch64/Neoverse/V1-misc-instructions.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,21 @@ sysl x16, #5, c11, c8, #5
# CHECK-NEXT: [6]: HasSideEffects (U)

# CHECK: [1] [2] [3] [4] [5] [6] Instructions:
# CHECK-NEXT: 1 1 0.12 U at s12e1r, x28
# CHECK-NEXT: 1 1 0.12 U brk #0x8415
# CHECK-NEXT: 1 1 0.12 * * U clrex
# CHECK-NEXT: 1 1 0.12 * * U csdb
# CHECK-NEXT: 1 1 0.12 U dcps1
# CHECK-NEXT: 1 1 0.12 U dcps2
# CHECK-NEXT: 1 1 0.12 U dcps3
# CHECK-NEXT: 1 1 0.12 * * U dmb sy
# CHECK-NEXT: 1 1 0.12 U hlt #0x7a67
# CHECK-NEXT: 1 1 0.12 U hvc #0xecb9
# CHECK-NEXT: 1 1 0.12 * * U isb
# CHECK-NEXT: 1 1 0.12 * * U pssbb
# CHECK-NEXT: 1 1 0.12 U smc #0x7e57
# CHECK-NEXT: 1 1 0.12 U svc #0x89cb
# CHECK-NEXT: 1 1 0.12 U sysl x16, #5, c11, c8, #5
# CHECK-NEXT: 1 1 0.13 U at s12e1r, x28
# CHECK-NEXT: 1 1 0.13 U brk #0x8415
# CHECK-NEXT: 1 1 0.13 * * U clrex
# CHECK-NEXT: 1 1 0.13 * * U csdb
# CHECK-NEXT: 1 1 0.13 U dcps1
# CHECK-NEXT: 1 1 0.13 U dcps2
# CHECK-NEXT: 1 1 0.13 U dcps3
# CHECK-NEXT: 1 1 0.13 * * U dmb sy
# CHECK-NEXT: 1 1 0.13 U hlt #0x7a67
# CHECK-NEXT: 1 1 0.13 U hvc #0xecb9
# CHECK-NEXT: 1 1 0.13 * * U isb
# CHECK-NEXT: 1 1 0.13 * * U pssbb
# CHECK-NEXT: 1 1 0.13 U smc #0x7e57
# CHECK-NEXT: 1 1 0.13 U svc #0x89cb
# CHECK-NEXT: 1 1 0.13 U sysl x16, #5, c11, c8, #5

# CHECK: Resources:
# CHECK-NEXT: [0.0] - V1UnitB
Expand Down
18 changes: 9 additions & 9 deletions llvm/test/tools/llvm-mca/AArch64/Neoverse/V1-sve-instructions.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3991,19 +3991,19 @@ zip2 z31.s, z31.s, z31.s
# CHECK-NEXT: 2 2 2.00 2 V1UnitI[2],V1UnitM[2],V1UnitM0[2] ANDS_PPzPP movs p0.b, p0/z, p0.b
# CHECK-NEXT: 2 2 2.00 2 V1UnitI[2],V1UnitM[2],V1UnitM0[2] ORRS_PPzPP movs p15.b, p15.b
# CHECK-NEXT: 2 2 2.00 2 V1UnitI[2],V1UnitM[2],V1UnitM0[2] ANDS_PPzPP movs p15.b, p15/z, p15.b
# CHECK-NEXT: 1 1 0.12 U 1 MRS mrs x3, ID_AA64ZFR0_EL1
# CHECK-NEXT: 1 1 0.12 U 1 MRS mrs x3, ZCR_EL1
# CHECK-NEXT: 1 1 0.12 U 1 MRS mrs x3, ZCR_EL12
# CHECK-NEXT: 1 1 0.12 U 1 MRS mrs x3, ZCR_EL2
# CHECK-NEXT: 1 1 0.12 U 1 MRS mrs x3, ZCR_EL3
# CHECK-NEXT: 1 1 0.12 U 1 MSR msr ZCR_EL1, x3
# CHECK-NEXT: 1 1 0.13 U 1 MRS mrs x3, ID_AA64ZFR0_EL1
# CHECK-NEXT: 1 1 0.13 U 1 MRS mrs x3, ZCR_EL1
# CHECK-NEXT: 1 1 0.13 U 1 MRS mrs x3, ZCR_EL12
# CHECK-NEXT: 1 1 0.13 U 1 MRS mrs x3, ZCR_EL2
# CHECK-NEXT: 1 1 0.13 U 1 MRS mrs x3, ZCR_EL3
# CHECK-NEXT: 1 1 0.13 U 1 MSR msr ZCR_EL1, x3
# CHECK-NEXT: 2 5 2.00 2 V1UnitV[2],V1UnitV0[2],V1UnitV01[2],V1UnitV02[2] MSB_ZPmZZ_D msb z0.d, p0/m, z0.d, z0.d
# CHECK-NEXT: 1 4 1.00 4 V1UnitV,V1UnitV0,V1UnitV01,V1UnitV02 MSB_ZPmZZ_B msb z18.b, p1/m, z27.b, z0.b
# CHECK-NEXT: 1 4 1.00 4 V1UnitV,V1UnitV0,V1UnitV01,V1UnitV02 MSB_ZPmZZ_H msb z27.h, p5/m, z23.h, z1.h
# CHECK-NEXT: 1 4 1.00 4 V1UnitV,V1UnitV0,V1UnitV01,V1UnitV02 MSB_ZPmZZ_S msb z26.s, p2/m, z0.s, z2.s
# CHECK-NEXT: 1 1 0.12 U 1 MSR msr ZCR_EL12, x3
# CHECK-NEXT: 1 1 0.12 U 1 MSR msr ZCR_EL2, x3
# CHECK-NEXT: 1 1 0.12 U 1 MSR msr ZCR_EL3, x3
# CHECK-NEXT: 1 1 0.13 U 1 MSR msr ZCR_EL12, x3
# CHECK-NEXT: 1 1 0.13 U 1 MSR msr ZCR_EL2, x3
# CHECK-NEXT: 1 1 0.13 U 1 MSR msr ZCR_EL3, x3
# CHECK-NEXT: 1 4 1.00 4 V1UnitV,V1UnitV0,V1UnitV01,V1UnitV02 MUL_ZPmZ_B mul z0.b, p7/m, z0.b, z31.b
# CHECK-NEXT: 2 5 2.00 5 V1UnitV[2],V1UnitV0[2],V1UnitV01[2],V1UnitV02[2] MUL_ZPmZ_D mul z0.d, p7/m, z0.d, z31.d
# CHECK-NEXT: 1 4 1.00 4 V1UnitV,V1UnitV0,V1UnitV01,V1UnitV02 MUL_ZPmZ_H mul z0.h, p7/m, z0.h, z31.h
Expand Down
2 changes: 1 addition & 1 deletion llvm/tools/llvm-mca/Views/InstructionInfoView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ void InstructionInfoView::printView(raw_ostream &OS) const {
FOS.PadToColumn(Paddings[2]);
if (IIVDEntry.RThroughput) {
double RT = *IIVDEntry.RThroughput;
FOS << format("%.2f", RT);
FOS << format("%.2f", floor((RT * 100) + 0.5) / 100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there will be an implicit promotion but perhaps we could just spell out 100.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there will be an implicit promotion but perhaps we could just spell out 100.0?

I see what you mean, but in the spirit of "invisible mending", 100 matches the 30 or so other uses of implicitly promoted integer 100 in llvm-mca/Views.

} else {
FOS << " -";
}
Expand Down