Revert "[IR] Simplify HasCachedHash with is_detected (NFC) (#159510)"

[rupprecht]

This reverts commit d6b7ac8. Build breakages reported on the PR hint at not working with certain versions of the host compiler.

[llvmbot]

@llvm/pr-subscribers-llvm-ir

Author: Jordan Rupprecht (rupprecht)

Changes

This reverts commit d6b7ac8. Build breakages reported on the PR hint at not working with certain versions of the host compiler.

---

Full diff: https://github.com/llvm/llvm-project/pull/159622.diff

1 Files Affected:

• (modified) llvm/lib/IR/Metadata.cpp (+7-2)

diff --git a/llvm/lib/IR/Metadata.cpp b/llvm/lib/IR/Metadata.cpp
index 09e25ceaf59c3..fc78a5b299f49 100644
--- a/llvm/lib/IR/Metadata.cpp
+++ b/llvm/lib/IR/Metadata.cpp
@@ -986,10 +986,15 @@ static T *uniquifyImpl(T *N, DenseSet<T *, InfoT> &Store) {
 }
 
 template <class NodeTy> struct MDNode::HasCachedHash {
+  using Yes = char[1];
+  using No = char[2];
+  template <class U, U Val> struct SFINAE {};
+
   template <class U>
-  using check = decltype(static_cast<void (U::*)(unsigned)>(&U::setHash));
+  static Yes &check(SFINAE<void (U::*)(unsigned), &U::setHash> *);
+  template <class U> static No &check(...);
 
-  static constexpr bool value = is_detected<check, NodeTy>::value;
+  static const bool value = sizeof(check<NodeTy>(nullptr)) == sizeof(Yes);
 };
 
 MDNode *MDNode::uniquify() {

[kazutakahirata]

LGTM. Thank you for taking care of this!