[mlir][arith] Simplify inheriting constructors declarations. NFC. #159682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `Base` type alias from llvm#158433.
kuhar
requested review from
banach-space,
dcaballe and
nicolasvasilache
as code owners
|
@llvm/pr-subscribers-mlir-emitc @llvm/pr-subscribers-backend-amdgpu Author: Jakub Kuderski (kuhar) ChangesUse the Full diff: https://github.com/llvm/llvm-project/pull/159682.diff 8 Files Affected:
diff --git a/mlir/lib/Conversion/ArithToAMDGPU/ArithToAMDGPU.cpp b/mlir/lib/Conversion/ArithToAMDGPU/ArithToAMDGPU.cpp
index 3d6f6cab42244..dcbaa5698d767 100644
--- a/mlir/lib/Conversion/ArithToAMDGPU/ArithToAMDGPU.cpp
+++ b/mlir/lib/Conversion/ArithToAMDGPU/ArithToAMDGPU.cpp
@@ -46,7 +46,7 @@ struct ArithToAMDGPUConversionPass final
};
struct ExtFOnFloat8RewritePattern final : OpRewritePattern<arith::ExtFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
Chipset chipset;
ExtFOnFloat8RewritePattern(MLIRContext *ctx, Chipset chipset,
@@ -72,7 +72,7 @@ struct TruncFToFloat8RewritePattern final : OpRewritePattern<arith::TruncFOp> {
struct TruncfToFloat16RewritePattern final
: public OpRewritePattern<arith::TruncFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::TruncFOp op,
PatternRewriter &rewriter) const override;
@@ -80,7 +80,7 @@ struct TruncfToFloat16RewritePattern final
struct ScalingExtFRewritePattern final
: OpRewritePattern<arith::ScalingExtFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::ScalingExtFOp op,
PatternRewriter &rewriter) const override;
@@ -88,7 +88,7 @@ struct ScalingExtFRewritePattern final
struct ScalingTruncFRewritePattern final
: OpRewritePattern<arith::ScalingTruncFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::ScalingTruncFOp op,
PatternRewriter &rewriter) const override;
diff --git a/mlir/lib/Conversion/ArithToArmSME/ArithToArmSME.cpp b/mlir/lib/Conversion/ArithToArmSME/ArithToArmSME.cpp
index ba489436a1a4d..ce929c14f66dd 100644
--- a/mlir/lib/Conversion/ArithToArmSME/ArithToArmSME.cpp
+++ b/mlir/lib/Conversion/ArithToArmSME/ArithToArmSME.cpp
@@ -44,7 +44,7 @@ namespace {
/// Conversion pattern for dense arith.constant.
struct ConstantOpToArmSMELowering : public OpRewritePattern<arith::ConstantOp> {
- using OpRewritePattern<arith::ConstantOp>::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::ConstantOp constantOp,
PatternRewriter &rewriter) const final {
diff --git a/mlir/lib/Conversion/ArithToEmitC/ArithToEmitC.cpp b/mlir/lib/Conversion/ArithToEmitC/ArithToEmitC.cpp
index b68933d0fb0a0..02091a407ac11 100644
--- a/mlir/lib/Conversion/ArithToEmitC/ArithToEmitC.cpp
+++ b/mlir/lib/Conversion/ArithToEmitC/ArithToEmitC.cpp
@@ -52,7 +52,7 @@ namespace {
class ArithConstantOpConversionPattern
: public OpConversionPattern<arith::ConstantOp> {
public:
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::ConstantOp arithConst,
@@ -94,7 +94,7 @@ Value adaptValueType(Value val, ConversionPatternRewriter &rewriter, Type ty) {
class CmpFOpConversion : public OpConversionPattern<arith::CmpFOp> {
public:
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::CmpFOp op, OpAdaptor adaptor,
@@ -248,7 +248,7 @@ class CmpFOpConversion : public OpConversionPattern<arith::CmpFOp> {
class CmpIOpConversion : public OpConversionPattern<arith::CmpIOp> {
public:
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
bool needsUnsignedCmp(arith::CmpIPredicate pred) const {
switch (pred) {
@@ -314,7 +314,7 @@ class CmpIOpConversion : public OpConversionPattern<arith::CmpIOp> {
class NegFOpConversion : public OpConversionPattern<arith::NegFOp> {
public:
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::NegFOp op, OpAdaptor adaptor,
@@ -647,7 +647,7 @@ class UnsignedShiftOpConversion final
class SelectOpConversion : public OpConversionPattern<arith::SelectOp> {
public:
- using OpConversionPattern<arith::SelectOp>::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::SelectOp selectOp, OpAdaptor adaptor,
diff --git a/mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp b/mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp
index cb0c829719565..ba57155ab9b45 100644
--- a/mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp
+++ b/mlir/lib/Conversion/ArithToLLVM/ArithToLLVM.cpp
@@ -57,7 +57,7 @@ struct ConstrainedVectorConvertToLLVMPattern
/// are the same.
struct IdentityBitcastLowering final
: public OpConversionPattern<arith::BitcastOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::BitcastOp op, OpAdaptor adaptor,
diff --git a/mlir/lib/Conversion/TosaToArith/TosaToArith.cpp b/mlir/lib/Conversion/TosaToArith/TosaToArith.cpp
index e568660c3d5df..67eb9fdb446d4 100644
--- a/mlir/lib/Conversion/TosaToArith/TosaToArith.cpp
+++ b/mlir/lib/Conversion/TosaToArith/TosaToArith.cpp
@@ -23,7 +23,7 @@ namespace {
class ConstOpConverter : public OpRewritePattern<tosa::ConstOp> {
public:
- using OpRewritePattern<tosa::ConstOp>::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(tosa::ConstOp op,
PatternRewriter &rewriter) const final {
@@ -60,7 +60,7 @@ Value getConstantValue(Location loc, Type type, int64_t value,
class ApplyScaleGenericOpConverter
: public OpRewritePattern<tosa::ApplyScaleOp> {
public:
- using OpRewritePattern<tosa::ApplyScaleOp>::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(tosa::ApplyScaleOp op,
PatternRewriter &rewriter) const final {
@@ -126,7 +126,7 @@ class ApplyScaleGenericOpConverter
class ApplyScale32BitOpConverter : public OpRewritePattern<tosa::ApplyScaleOp> {
public:
- using OpRewritePattern<tosa::ApplyScaleOp>::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(tosa::ApplyScaleOp op,
PatternRewriter &rewriter) const final {
diff --git a/mlir/lib/Dialect/Arith/IR/ArithOps.cpp b/mlir/lib/Dialect/Arith/IR/ArithOps.cpp
index 1fbb7a4784cd5..7cfd6d3a98df8 100644
--- a/mlir/lib/Dialect/Arith/IR/ArithOps.cpp
+++ b/mlir/lib/Dialect/Arith/IR/ArithOps.cpp
@@ -2137,7 +2137,7 @@ OpFoldResult arith::CmpFOp::fold(FoldAdaptor adaptor) {
class CmpFIntToFPConst final : public OpRewritePattern<CmpFOp> {
public:
- using OpRewritePattern<CmpFOp>::OpRewritePattern;
+ using Base::Base;
static CmpIPredicate convertToIntegerPredicate(CmpFPredicate pred,
bool isUnsigned) {
@@ -2431,7 +2431,7 @@ void arith::CmpFOp::getCanonicalizationPatterns(RewritePatternSet &patterns,
// select %arg, %c1, %c0 => extui %arg
struct SelectToExtUI : public OpRewritePattern<arith::SelectOp> {
- using OpRewritePattern<arith::SelectOp>::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::SelectOp op,
PatternRewriter &rewriter) const override {
diff --git a/mlir/lib/Dialect/Arith/Transforms/EmulateWideInt.cpp b/mlir/lib/Dialect/Arith/Transforms/EmulateWideInt.cpp
index efe6ad2579055..36765d7b27418 100644
--- a/mlir/lib/Dialect/Arith/Transforms/EmulateWideInt.cpp
+++ b/mlir/lib/Dialect/Arith/Transforms/EmulateWideInt.cpp
@@ -173,7 +173,7 @@ namespace {
//===----------------------------------------------------------------------===//
struct ConvertConstant final : OpConversionPattern<arith::ConstantOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::ConstantOp op, OpAdaptor,
@@ -235,7 +235,7 @@ struct ConvertConstant final : OpConversionPattern<arith::ConstantOp> {
//===----------------------------------------------------------------------===//
struct ConvertAddI final : OpConversionPattern<arith::AddIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::AddIOp op, OpAdaptor adaptor,
@@ -325,7 +325,7 @@ static arith::CmpIPredicate toUnsignedPredicate(arith::CmpIPredicate pred) {
}
struct ConvertCmpI final : OpConversionPattern<arith::CmpIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::CmpIOp op, OpAdaptor adaptor,
@@ -381,7 +381,7 @@ struct ConvertCmpI final : OpConversionPattern<arith::CmpIOp> {
//===----------------------------------------------------------------------===//
struct ConvertMulI final : OpConversionPattern<arith::MulIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::MulIOp op, OpAdaptor adaptor,
@@ -422,7 +422,7 @@ struct ConvertMulI final : OpConversionPattern<arith::MulIOp> {
//===----------------------------------------------------------------------===//
struct ConvertExtSI final : OpConversionPattern<arith::ExtSIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::ExtSIOp op, OpAdaptor adaptor,
@@ -460,7 +460,7 @@ struct ConvertExtSI final : OpConversionPattern<arith::ExtSIOp> {
//===----------------------------------------------------------------------===//
struct ConvertExtUI final : OpConversionPattern<arith::ExtUIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::ExtUIOp op, OpAdaptor adaptor,
@@ -598,7 +598,7 @@ struct ConvertIndexCastIndexToInt final : OpConversionPattern<CastOp> {
//===----------------------------------------------------------------------===//
struct ConvertSelect final : OpConversionPattern<arith::SelectOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::SelectOp op, OpAdaptor adaptor,
@@ -631,7 +631,7 @@ struct ConvertSelect final : OpConversionPattern<arith::SelectOp> {
//===----------------------------------------------------------------------===//
struct ConvertShLI final : OpConversionPattern<arith::ShLIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::ShLIOp op, OpAdaptor adaptor,
@@ -720,7 +720,7 @@ struct ConvertShLI final : OpConversionPattern<arith::ShLIOp> {
//===----------------------------------------------------------------------===//
struct ConvertShRUI final : OpConversionPattern<arith::ShRUIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::ShRUIOp op, OpAdaptor adaptor,
@@ -809,7 +809,7 @@ struct ConvertShRUI final : OpConversionPattern<arith::ShRUIOp> {
//===----------------------------------------------------------------------===//
struct ConvertShRSI final : OpConversionPattern<arith::ShRSIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::ShRSIOp op, OpAdaptor adaptor,
@@ -872,7 +872,7 @@ struct ConvertShRSI final : OpConversionPattern<arith::ShRSIOp> {
//===----------------------------------------------------------------------===//
struct ConvertSubI final : OpConversionPattern<arith::SubIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::SubIOp op, OpAdaptor adaptor,
@@ -912,7 +912,7 @@ struct ConvertSubI final : OpConversionPattern<arith::SubIOp> {
//===----------------------------------------------------------------------===//
struct ConvertSIToFP final : OpConversionPattern<arith::SIToFPOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::SIToFPOp op, OpAdaptor adaptor,
@@ -951,7 +951,7 @@ struct ConvertSIToFP final : OpConversionPattern<arith::SIToFPOp> {
//===----------------------------------------------------------------------===//
struct ConvertUIToFP final : OpConversionPattern<arith::UIToFPOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::UIToFPOp op, OpAdaptor adaptor,
@@ -1015,7 +1015,7 @@ struct ConvertUIToFP final : OpConversionPattern<arith::UIToFPOp> {
//===----------------------------------------------------------------------===//
struct ConvertFPToSI final : OpConversionPattern<arith::FPToSIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::FPToSIOp op, OpAdaptor adaptor,
@@ -1065,7 +1065,7 @@ struct ConvertFPToSI final : OpConversionPattern<arith::FPToSIOp> {
//===----------------------------------------------------------------------===//
struct ConvertFPToUI final : OpConversionPattern<arith::FPToUIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::FPToUIOp op, OpAdaptor adaptor,
@@ -1137,7 +1137,7 @@ struct ConvertFPToUI final : OpConversionPattern<arith::FPToUIOp> {
//===----------------------------------------------------------------------===//
struct ConvertTruncI final : OpConversionPattern<arith::TruncIOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(arith::TruncIOp op, OpAdaptor adaptor,
@@ -1166,7 +1166,7 @@ struct ConvertTruncI final : OpConversionPattern<arith::TruncIOp> {
//===----------------------------------------------------------------------===//
struct ConvertVectorPrint final : OpConversionPattern<vector::PrintOp> {
- using OpConversionPattern::OpConversionPattern;
+ using Base::Base;
LogicalResult
matchAndRewrite(vector::PrintOp op, OpAdaptor adaptor,
diff --git a/mlir/lib/Dialect/Arith/Transforms/ExpandOps.cpp b/mlir/lib/Dialect/Arith/Transforms/ExpandOps.cpp
index f8fa35c6fa7de..6e7421daeb223 100644
--- a/mlir/lib/Dialect/Arith/Transforms/ExpandOps.cpp
+++ b/mlir/lib/Dialect/Arith/Transforms/ExpandOps.cpp
@@ -59,7 +59,7 @@ namespace {
/// Expands CeilDivUIOp (n, m) into
/// n == 0 ? 0 : ((n-1) / m) + 1
struct CeilDivUIOpConverter : public OpRewritePattern<arith::CeilDivUIOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::CeilDivUIOp op,
PatternRewriter &rewriter) const final {
Location loc = op.getLoc();
@@ -85,7 +85,7 @@ struct CeilDivUIOpConverter : public OpRewritePattern<arith::CeilDivUIOp> {
/// return z;
/// }
struct CeilDivSIOpConverter : public OpRewritePattern<arith::CeilDivSIOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::CeilDivSIOp op,
PatternRewriter &rewriter) const final {
Location loc = op.getLoc();
@@ -127,7 +127,7 @@ struct CeilDivSIOpConverter : public OpRewritePattern<arith::CeilDivSIOp> {
/// return z;
/// }
struct FloorDivSIOpConverter : public OpRewritePattern<arith::FloorDivSIOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::FloorDivSIOp op,
PatternRewriter &rewriter) const final {
Location loc = op.getLoc();
@@ -230,7 +230,7 @@ struct MaxNumMinNumFOpConverter : public OpRewritePattern<OpTy> {
};
struct BFloat16ExtFOpConverter : public OpRewritePattern<arith::ExtFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::ExtFOp op,
PatternRewriter &rewriter) const final {
ImplicitLocOpBuilder b(op.getLoc(), rewriter);
@@ -260,7 +260,7 @@ struct BFloat16ExtFOpConverter : public OpRewritePattern<arith::ExtFOp> {
};
struct BFloat16TruncFOpConverter : public OpRewritePattern<arith::TruncFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::TruncFOp op,
PatternRewriter &rewriter) const final {
ImplicitLocOpBuilder b(op.getLoc(), rewriter);
@@ -364,7 +364,7 @@ struct BFloat16TruncFOpConverter : public OpRewritePattern<arith::TruncFOp> {
///
/// 4) F32 bits[1:22] = 0
struct F4E2M1ExtFOpConverter : public OpRewritePattern<arith::ExtFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::ExtFOp op,
PatternRewriter &rewriter) const final {
Location loc = op.getLoc();
@@ -430,7 +430,7 @@ struct F4E2M1ExtFOpConverter : public OpRewritePattern<arith::ExtFOp> {
};
struct F8E8M0ExtFOpConverter : public OpRewritePattern<arith::ExtFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::ExtFOp op,
PatternRewriter &rewriter) const final {
ImplicitLocOpBuilder b(op.getLoc(), rewriter);
@@ -502,7 +502,7 @@ struct F8E8M0ExtFOpConverter : public OpRewritePattern<arith::ExtFOp> {
/// Step 5: Round up if necessary, if mantissa[1:] greater than 1000000 or
/// subnormal.
struct F4E2M1TruncFOpConverter : public OpRewritePattern<arith::TruncFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::TruncFOp op,
PatternRewriter &rewriter) const final {
Location loc = op.getLoc();
@@ -603,7 +603,7 @@ Since All kinds of Infs and NaNs are mapped to same exponent bits in F32 type,
they all map to NaN in F8E8M0 Type.
*/
struct F8E8M0TruncFOpConverter : public OpRewritePattern<arith::TruncFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::TruncFOp op,
PatternRewriter &rewriter) const final {
ImplicitLocOpBuilder b(op.getLoc(), rewriter);
@@ -642,7 +642,7 @@ struct F8E8M0TruncFOpConverter : public OpRewritePattern<arith::TruncFOp> {
};
struct ScalingExtFOpConverter : public OpRewritePattern<arith::ScalingExtFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::ScalingExtFOp op,
PatternRewriter &rewriter) const final {
ImplicitLocOpBuilder b(op.getLoc(), rewriter);
@@ -684,7 +684,7 @@ Expands arith.ScalingTruncFOp(in, scale) into
*/
struct ScalingTruncFOpConverter
: public OpRewritePattern<arith::ScalingTruncFOp> {
- using OpRewritePattern::OpRewritePattern;
+ using Base::Base;
LogicalResult matchAndRewrite(arith::ScalingTruncFOp op,
PatternRewriter &rewriter) const final {
ImplicitLocOpBuilder b(op.getLoc(), rewriter);
|
SeongjaeP
pushed a commit
to SeongjaeP/llvm-project
that referenced
this pull request
Sep 23, 2025
…vm#159682) Use the `Base` type alias from llvm#158433.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
Basetype alias from #158433.