TableGen: Replace assertion with error for unexpected pattern inputs

[arsenm]

No description provided.

[arsenm]

• TableGen: Replace assertion with error for unexpected pattern inputs #159687 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-tablegen

Author: Matt Arsenault (arsenm)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/159687.diff

2 Files Affected:

• (added) llvm/test/TableGen/dag-pattern-crash-on-set.td (+25)
• (modified) llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp (+4-1)

diff --git a/llvm/test/TableGen/dag-pattern-crash-on-set.td b/llvm/test/TableGen/dag-pattern-crash-on-set.td
new file mode 100644
index 0000000000000..dd273228033ff
--- /dev/null
+++ b/llvm/test/TableGen/dag-pattern-crash-on-set.td
@@ -0,0 +1,25 @@
+// RUN: not llvm-tblgen -gen-dag-isel -I %p/../../include -o /dev/null %s 2>&1 | FileCheck %s
+
+include "llvm/Target/Target.td"
+
+def MyTargetInstrInfo : InstrInfo;
+def MyTarget : Target {
+  let InstructionSet = MyTargetInstrInfo;
+}
+
+def R0 : Register<"r0">;
+def GPR : RegisterClass<"MyTarget", [i32], 32, (add R0)>;
+
+def LOAD : Instruction {
+  let Size = 2;
+  let OutOperandList = (outs GPR:$dst);
+  let InOperandList = (ins GPR:$addr);
+  let AsmString = "movimm $dst, $addr";
+}
+
+// CHECK: [[@LINE+1]]:5: error: In CrashPat: unknown node type 'set in input pattern
+def CrashPat : Pat <
+  (set R0, (load GPR:$addr)),
+  (LOAD $addr)
+>;
+
diff --git a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
index f1f7cd72ef9f2..22bcf733501a4 100644
--- a/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
+++ b/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp
@@ -2795,7 +2795,10 @@ bool TreePatternNode::ApplyTypeConstraints(TreePattern &TP, bool NotRegisters) {
     return MadeChange;
   }
 
-  assert(getOperator()->isSubClassOf("SDNodeXForm") && "Unknown node type!");
+  if (!getOperator()->isSubClassOf("SDNodeXForm")) {
+    TP.error("unknown node type '" + getOperator()->getName() + " in input pattern");
+    return false;
+  }
 
   // Node transforms always take one operand.
   if (getNumChildren() != 1) {

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[s-barannikov]

I was thinking of supporting this syntax on top-level patterns, but trying to implement it revealed several issues that are not trivial to fix.