[MC] Make -mcpu=native test target specific
#159868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not possible to use `-mcpu=native` when the Target's Triple doesn't match the Host's. Move this test to the AArch64 directory so that it isn't run while cross-compiling. Originally llvm#159414
|
@llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-backend-aarch64 Author: Cameron McInally (mcinally) ChangesIt's not possible to use Originally #159414 Full diff: https://github.com/llvm/llvm-project/pull/159868.diff 2 Files Affected:
diff --git a/llvm/test/MC/AArch64/mcpu-native.s b/llvm/test/MC/AArch64/mcpu-native.s
new file mode 100644
index 0000000000000..56c216091372b
--- /dev/null
+++ b/llvm/test/MC/AArch64/mcpu-native.s
@@ -0,0 +1,5 @@
+# REQUIRES: aarch64-registered-target,system-linux,aarch64-host
+# RUN: llvm-mc -triple=aarch64 -filetype=obj -o %t -mcpu=native %s 2> %t.stderr
+# RUN: FileCheck --allow-empty %s < %t.stderr
+
+# CHECK-NOT: {{.+}}
diff --git a/llvm/test/MC/AsmParser/native.s b/llvm/test/MC/AsmParser/native.s
deleted file mode 100644
index 4da5b3717913f..0000000000000
--- a/llvm/test/MC/AsmParser/native.s
+++ /dev/null
@@ -1,4 +0,0 @@
-# RUN: llvm-mc -filetype=obj -o %t -mcpu=native %s 2> %t.stderr
-# RUN: FileCheck --allow-empty %s < %t.stderr
-
-# CHECK-NOT: {{.+}}
|
X86 has more convenient REQUIRES features. Use them.
|
Please update the description, it still mentions AArch64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to use
-mcpu=nativewhen the Target's Triple doesn't match the Host's. Move this test to the X86 directory so that it isn't run while cross-compiling.Originally #159414