Skip to content

[libc++][NFC] Remove guard around noop_coroutine_handle.h #160044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

[libc++][NFC] Remove guard around noop_coroutine_handle.h #160044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions libcxx/include/__coroutine/noop_coroutine_handle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

_LIBCPP_BEGIN_NAMESPACE_STD

# if __has_builtin(__builtin_coro_noop) || defined(_LIBCPP_COMPILER_GCC)

// [coroutine.noop]
// [coroutine.promise.noop]
struct noop_coroutine_promise {};
Expand Down Expand Up @@ -56,12 +54,12 @@ struct coroutine_handle<noop_coroutine_promise> {
private:
_LIBCPP_HIDE_FROM_ABI friend coroutine_handle<noop_coroutine_promise> noop_coroutine() noexcept;

# if __has_builtin(__builtin_coro_noop)
# if __has_builtin(__builtin_coro_noop)
_LIBCPP_HIDE_FROM_ABI coroutine_handle() noexcept { this->__handle_ = __builtin_coro_noop(); }

void* __handle_ = nullptr;

# elif defined(_LIBCPP_COMPILER_GCC)
# elif defined(_LIBCPP_COMPILER_GCC)
// GCC doesn't implement __builtin_coro_noop().
// Construct the coroutine frame manually instead.
struct __noop_coroutine_frame_ty_ {
Expand All @@ -78,20 +76,18 @@ struct coroutine_handle<noop_coroutine_promise> {

_LIBCPP_HIDE_FROM_ABI coroutine_handle() noexcept = default;

# endif // __has_builtin(__builtin_coro_noop)
# endif // __has_builtin(__builtin_coro_noop)
};

using noop_coroutine_handle = coroutine_handle<noop_coroutine_promise>;

# if defined(_LIBCPP_COMPILER_GCC)
# if defined(_LIBCPP_COMPILER_GCC)
inline noop_coroutine_handle::__noop_coroutine_frame_ty_ noop_coroutine_handle::__noop_coroutine_frame_{};
# endif
# endif

// [coroutine.noop.coroutine]
inline _LIBCPP_HIDE_FROM_ABI noop_coroutine_handle noop_coroutine() noexcept { return noop_coroutine_handle(); }

# endif // __has_builtin(__builtin_coro_noop) || defined(_LIBCPP_COMPILER_GCC)

_LIBCPP_END_NAMESPACE_STD

#endif // _LIBCPP_STD_VER >= 20
Expand Down
Loading