Skip to content

Conversation

ellishg
Copy link
Contributor

@ellishg ellishg commented Sep 22, 2025

Fix a test added in #158720. I had accidentally required arm64 when the test was using x86_64.

@llvmbot
Copy link
Member

llvmbot commented Sep 22, 2025

@llvm/pr-subscribers-lld

Author: Ellis Hoag (ellishg)

Changes

Fix a test added in #158720. I had accidentally required arm64 when the test was using x86_64.


Full diff: https://github.com/llvm/llvm-project/pull/160172.diff

1 Files Affected:

  • (modified) lld/test/MachO/cstring.ll (+1-1)
diff --git a/lld/test/MachO/cstring.ll b/lld/test/MachO/cstring.ll
index 4f82736b0a5f0..4ba9082427b85 100644
--- a/lld/test/MachO/cstring.ll
+++ b/lld/test/MachO/cstring.ll
@@ -1,4 +1,4 @@
-; REQUIRES: aarch64
+; REQUIRES: x86
 ; RUN: llvm-as %s -o %t.o
 
 ; RUN: %lld -dylib --separate-cstring-literal-sections %t.o -o - | llvm-objdump --macho --section-headers - | FileCheck %s

@llvmbot
Copy link
Member

llvmbot commented Sep 22, 2025

@llvm/pr-subscribers-lld-macho

Author: Ellis Hoag (ellishg)

Changes

Fix a test added in #158720. I had accidentally required arm64 when the test was using x86_64.


Full diff: https://github.com/llvm/llvm-project/pull/160172.diff

1 Files Affected:

  • (modified) lld/test/MachO/cstring.ll (+1-1)
diff --git a/lld/test/MachO/cstring.ll b/lld/test/MachO/cstring.ll
index 4f82736b0a5f0..4ba9082427b85 100644
--- a/lld/test/MachO/cstring.ll
+++ b/lld/test/MachO/cstring.ll
@@ -1,4 +1,4 @@
-; REQUIRES: aarch64
+; REQUIRES: x86
 ; RUN: llvm-as %s -o %t.o
 
 ; RUN: %lld -dylib --separate-cstring-literal-sections %t.o -o - | llvm-objdump --macho --section-headers - | FileCheck %s

@ellishg ellishg requested a review from kyulee-com September 22, 2025 18:45
@ellishg ellishg enabled auto-merge (squash) September 22, 2025 18:50
@ellishg ellishg disabled auto-merge September 22, 2025 18:51
@ellishg ellishg merged commit d86dac9 into llvm:main Sep 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants