Skip to content

[SDPatternMatcher] Remove std::optional around SDNodeFlags in BinaryOpc_match. NFC #160178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

[SDPatternMatcher] Remove std::optional around SDNodeFlags in BinaryOpc_match. NFC #160178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions llvm/include/llvm/CodeGen/SDPatternMatch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,9 +597,9 @@ struct BinaryOpc_match {
unsigned Opcode;
LHS_P LHS;
RHS_P RHS;
std::optional<SDNodeFlags> Flags;
SDNodeFlags Flags;
BinaryOpc_match(unsigned Opc, const LHS_P &L, const RHS_P &R,
std::optional<SDNodeFlags> Flgs = std::nullopt)
SDNodeFlags Flgs = SDNodeFlags())
: Opcode(Opc), LHS(L), RHS(R), Flags(Flgs) {}

template <typename MatchContext>
Expand All @@ -613,10 +613,7 @@ struct BinaryOpc_match {
RHS.match(Ctx, N->getOperand(EO.FirstIndex)))))
return false;

if (!Flags.has_value())
return true;

return (*Flags & N->getFlags()) == *Flags;
return (Flags & N->getFlags()) == Flags;
}

return false;
Expand Down