Skip to content

[Offload] Print Image location rather than casting it #160309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

[Offload] Print Image location rather than casting it #160309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
893325e
[Offload] Print Image location rather than casting it
RossBrunton Sep 23, 2025
39f8521
Prase be to clang-format
RossBrunton Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions offload/plugins-nextgen/common/src/PluginInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1714,7 +1714,8 @@ int32_t GenericPluginTy::is_initialized() const { return Initialized; }
int32_t GenericPluginTy::isPluginCompatible(StringRef Image) {
auto HandleError = [&](Error Err) -> bool {
[[maybe_unused]] std::string ErrStr = toString(std::move(Err));
DP("Failure to check validity of image %p: %s", Image, ErrStr.c_str());
DP("Failure to check validity of image %p: %s", Image.data(),
ErrStr.c_str());
return false;
};
switch (identify_magic(Image)) {
Expand Down Expand Up @@ -1742,7 +1743,8 @@ int32_t GenericPluginTy::isPluginCompatible(StringRef Image) {
int32_t GenericPluginTy::isDeviceCompatible(int32_t DeviceId, StringRef Image) {
auto HandleError = [&](Error Err) -> bool {
[[maybe_unused]] std::string ErrStr = toString(std::move(Err));
DP("Failure to check validity of image %p: %s", Image, ErrStr.c_str());
DP("Failure to check validity of image %p: %s", Image.data(),
ErrStr.c_str());
return false;
};
switch (identify_magic(Image)) {
Expand Down
Loading