Skip to content

Conversation

cmtice
Copy link
Contributor

@cmtice cmtice commented Sep 23, 2025

This adds a link to the dashboard that shows premerge testing queue and run times for libc++ testing, to the Contributing.rst document.

This adds a link to the dashboard that shows premerge testing
quueue and run times for libc++ testing, to the Contributing.rst
document.
@cmtice cmtice marked this pull request as ready for review September 23, 2025 16:54
@cmtice cmtice requested a review from a team as a code owner September 23, 2025 16:54
@cmtice cmtice requested a review from ldionne September 23, 2025 16:54
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 23, 2025
@cmtice cmtice requested a review from EricWF September 23, 2025 16:54
@llvmbot
Copy link
Member

llvmbot commented Sep 23, 2025

@llvm/pr-subscribers-libcxx

Author: None (cmtice)

Changes

This adds a link to the dashboard that shows premerge testing queue and run times for libc++ testing, to the Contributing.rst document.


Full diff: https://github.com/llvm/llvm-project/pull/160342.diff

1 Files Affected:

  • (modified) libcxx/docs/Contributing.rst (+11)
diff --git a/libcxx/docs/Contributing.rst b/libcxx/docs/Contributing.rst
index ac856195ad68e..695fc95aad872 100644
--- a/libcxx/docs/Contributing.rst
+++ b/libcxx/docs/Contributing.rst
@@ -330,6 +330,17 @@ has been merged, an LLVM premerge maintainer (a Google employee) must use
 terraform to apply the change to the running GKE cluster.
 
 
+monitoring premerge testing performance
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The llvm-premerge-libcxx runners mentioned above collect metrics regarding the
+time the tests spend queued up before they start running and also the time it
+takes the tests to actually complete running. These metrics are collected and
+aggregated (based on stage and PR), and the results can be seen at this
+`Libc++ Premerge Testing dashboard
+<https://llvm.grafana.net/public-dashboards/0bd453e8b3034733a1b0ff8c7728086d>`__
+.
+
 run-buildbot-container
 ~~~~~~~~~~~~~~~~~~~~~~
 

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Someone from the libc++ side needs to review this as well though.

terraform to apply the change to the running GKE cluster.


monitoring premerge testing performance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Given this is a section title, it should probably be capitalized as such.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

The llvm-premerge-libcxx runners mentioned above collect metrics regarding the
time the tests spend queued up before they start running and also the time it
takes the tests to actually complete running. These metrics are collected and
aggregated (based on stage and PR), and the results can be seen at this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/this/the

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@philnik777 philnik777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware this existed. Thanks!

@cmtice cmtice merged commit ec27c2d into llvm:main Sep 25, 2025
79 checks passed
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Oct 3, 2025
This adds a link to the dashboard that shows premerge testing queue and
run times for libc++ testing, to the Contributing.rst document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants