-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[libc++] Add link to premerge tesing dashboard to docs. #160342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds a link to the dashboard that shows premerge testing quueue and run times for libc++ testing, to the Contributing.rst document.
@llvm/pr-subscribers-libcxx Author: None (cmtice) ChangesThis adds a link to the dashboard that shows premerge testing queue and run times for libc++ testing, to the Contributing.rst document. Full diff: https://github.com/llvm/llvm-project/pull/160342.diff 1 Files Affected:
diff --git a/libcxx/docs/Contributing.rst b/libcxx/docs/Contributing.rst
index ac856195ad68e..695fc95aad872 100644
--- a/libcxx/docs/Contributing.rst
+++ b/libcxx/docs/Contributing.rst
@@ -330,6 +330,17 @@ has been merged, an LLVM premerge maintainer (a Google employee) must use
terraform to apply the change to the running GKE cluster.
+monitoring premerge testing performance
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+The llvm-premerge-libcxx runners mentioned above collect metrics regarding the
+time the tests spend queued up before they start running and also the time it
+takes the tests to actually complete running. These metrics are collected and
+aggregated (based on stage and PR), and the results can be seen at this
+`Libc++ Premerge Testing dashboard
+<https://llvm.grafana.net/public-dashboards/0bd453e8b3034733a1b0ff8c7728086d>`__
+.
+
run-buildbot-container
~~~~~~~~~~~~~~~~~~~~~~
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Someone from the libc++ side needs to review this as well though.
libcxx/docs/Contributing.rst
Outdated
terraform to apply the change to the running GKE cluster. | ||
|
||
|
||
monitoring premerge testing performance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Given this is a section title, it should probably be capitalized as such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
libcxx/docs/Contributing.rst
Outdated
The llvm-premerge-libcxx runners mentioned above collect metrics regarding the | ||
time the tests spend queued up before they start running and also the time it | ||
takes the tests to actually complete running. These metrics are collected and | ||
aggregated (based on stage and PR), and the results can be seen at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: s/this/the
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware this existed. Thanks!
This adds a link to the dashboard that shows premerge testing queue and run times for libc++ testing, to the Contributing.rst document.
This adds a link to the dashboard that shows premerge testing queue and run times for libc++ testing, to the Contributing.rst document.