Skip to content

[libc++] Reduce the number of warnings when running SPEC #160366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

[libc++] Reduce the number of warnings when running SPEC #160366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion libcxx/test/benchmarks/spec.gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
link_flags = (test_dir / 'link_flags.subs').open().read().strip()
spec_dir = pathlib.Path((test_dir / 'spec_dir.subs').open().read().strip())

# Remove -Wall, -Wextra and -Werror from the flags since we don't care about enabling all warnings inside SPEC
compile_flags = compile_flags.replace('-Wall', '').replace('-Wextra', '').replace('-Werror', '')
Comment on lines +31 to +32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we ever care about the warnings, do we? In that case we might as well just pass -w.


# Setup the configuration file
test_dir.mkdir(parents=True, exist_ok=True)
spec_config = test_dir / 'spec-config.cfg'
Expand All @@ -46,7 +49,7 @@
copies = 1
threads = 1
CC = cc -O3
CXX = {cxx} {compile_flags} {flags} {link_flags} -Wno-error
CXX = {cxx} {compile_flags} {flags} {link_flags}
CC_VERSION_OPTION = --version
CXX_VERSION_OPTION = --version
EXTRA_PORTABILITY = -DSPEC_NO_CXX17_SPECIAL_MATH_FUNCTIONS # because libc++ doesn't implement the special math functions yet
Expand Down
Loading