-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[AMDGPU]: Rewrite mbcnt_lo/mbcnt_hi to work item ID where applicable #160496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TejaX-Alaghari
wants to merge
6
commits into
llvm:main
Choose a base branch
from
TejaX-Alaghari:mbcnt-to-workitem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+658
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
321ec3d
[AMDGPU] Move mbcnt optimization from InstCombine to AMDGPUCodeGenPre…
TejaX-Alaghari aadd53e
[AMDGPU] Enhance mbcnt.lo optimization to support bitmask cases
TejaX-Alaghari 9425aef
Fix mbcnt.hi wave32 optimization to respect reqd_work_group_size meta…
TejaX-Alaghari 3348dd0
Address review feedback: Add periods to all comments
TejaX-Alaghari 92f43e4
Address review comments from @arsenm
TejaX-Alaghari 73667ff
Refactored test cases and implementation comments
TejaX-Alaghari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arsenm, I believe
visitMbcntLo
&visitMbcntHi
should not be const because they are transformation functions that directly modify the IR. Please correct me if I'm missing something.