[llvm-remarkutil] Auto-detect serializer format based on file extension #160545
Conversation
Created using spr 1.3.7-wip
tobias-stadler
requested review from
fhahn and
jroelofs
and removed request for
fhahn
| } | ||
| Format SerializerFormat = | ||
| getSerializerFormat(OutputFileName, OutputFormat, Parser.ParserFormat); | ||
|
|
There was a problem hiding this comment.
WDYT about making the default be bitstream (unless the input was yaml), and then adding a warning/error message here if the output is a tty, kind of like opt does when you try to write bitcode to the terminal? I think our "north star" should be to converge on "bitstream for everything except LIT tests".
There was a problem hiding this comment.
It's a difficult trade-off imo. Working with these tools interactively in a tty, I personally like YAML as the default. I find that most often I call e.g. filter on huge bitstream files and pipe the result straight into vim/less for inspection. So if we do this, maybe instead of emitting the warning we can auto-switch to YAML if we detect tty and also add sth like -S as a shorthand for --serializer=yaml to make piping into text based tools easier?
If serializer format is set to Auto, try to detect user intent based on the file extension of the output file name. Pull Request: llvm#160545
If serializer format is set to Auto, try to detect user intent based on
the file extension of the output file name.