Skip to content

[clang-tidy][bazel][NFC] enable custom checks in bazel build #160548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+60 −3
Open

[clang-tidy][bazel][NFC] enable custom checks in bazel build #160548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d40af6
[clang-tidy][bazel][NFC] enable custom checks in bazel build
HerrCai0907 Sep 24, 2025
161e23d
Merge branch 'main' into enable-bazel-build-clang-tidy-custom-check
HerrCai0907 Oct 8, 2025
7b5ca5e
Merge branch 'main' into enable-bazel-build-clang-tidy-custom-check
HerrCai0907 Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions utils/bazel/llvm-project-overlay/clang-tools-extra/clang-query/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# This file is licensed under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception

load("@rules_cc//cc:defs.bzl", "cc_library")

package(
default_visibility = ["//visibility:public"],
features = ["layering_check"],
)

licenses(["notice"])

cc_library(
name = "lib",
srcs = glob(["*.cpp"]),
hdrs = glob(["*.h"]),
deps = [
"//clang:ast",
"//clang:ast_matchers",
"//clang:ast_matchers_dynamic",
"//clang:basic",
"//clang:frontend",
"//clang:serialization",
"//llvm:LineEditor",
"//llvm:Support",
],
)
35 changes: 32 additions & 3 deletions utils/bazel/llvm-project-overlay/clang-tools-extra/clang-tidy/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,37 @@ bool_flag(
build_setting_default = True,
)

bool_flag(
name = "enable_custom_checks",
build_setting_default = True,
)

config_setting(
name = "static_analyzer_enabled",
flag_values = {
":enable_static_analyzer": "true",
},
)

config_setting(
name = "custom_checks_enabled",
flag_values = {
":enable_custom_checks": "true",
},
)

expand_template(
name = "config",
out = "clang-tidy-config.h",
substitutions =
{
"#cmakedefine01 CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS": "#define CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS 0",
} | select({
select({
":custom_checks_enabled": {
"#cmakedefine01 CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS": "#define CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS 1",
},
"//conditions:default": {
"#cmakedefine01 CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS": "#define CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS 0",
},
}) | select({
":static_analyzer_enabled": {
"#cmakedefine01 CLANG_TIDY_ENABLE_STATIC_ANALYZER": "#define CLANG_TIDY_ENABLE_STATIC_ANALYZER 1",
},
Expand Down Expand Up @@ -208,6 +225,15 @@ clang_tidy_library(
],
)

clang_tidy_library(
name = "custom",
deps = [
":lib",
"//clang:ast_matchers_dynamic",
"//clang-tools-extra/clang-query:lib",
],
)

clang_tidy_library(
name = "concurrency",
deps = [":lib"],
Expand Down Expand Up @@ -365,6 +391,9 @@ CHECKS = [
] + select({
":static_analyzer_enabled": [":mpi"],
"//conditions:default": [],
}) + select({
":custom_checks_enabled": [":custom"],
"//conditions:default": [],
})

cc_library(
Expand Down
Loading