Skip to content

Conversation

rampitec
Copy link
Collaborator

The test is supposed to check SCOPE_SE upgrade which was
removed and also does not present in the test.

The test is supposed to check SCOPE_SE upgrade which was
removed and also does not present in the test.
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rampitec rampitec marked this pull request as ready for review September 24, 2025 19:06
@llvmbot
Copy link
Member

llvmbot commented Sep 24, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Stanislav Mekhanoshin (rampitec)

Changes

The test is supposed to check SCOPE_SE upgrade which was
removed and also does not present in the test.


Full diff: https://github.com/llvm/llvm-project/pull/160584.diff

1 Files Affected:

  • (removed) llvm/test/CodeGen/AMDGPU/gfx1250-scratch-scope-se.ll (-94)
diff --git a/llvm/test/CodeGen/AMDGPU/gfx1250-scratch-scope-se.ll b/llvm/test/CodeGen/AMDGPU/gfx1250-scratch-scope-se.ll
deleted file mode 100644
index f0c9258358316..0000000000000
--- a/llvm/test/CodeGen/AMDGPU/gfx1250-scratch-scope-se.ll
+++ /dev/null
@@ -1,94 +0,0 @@
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
-; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1250 < %s | FileCheck -check-prefixes=GCN,GCN-SDAG %s
-; RUN: llc -global-isel -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1250 < %s | FileCheck -check-prefixes=GCN,GCN-GISEL %s
-
-; Test that stores that may hit scratch are correctly promoted to SCOPE_SE.
-
-define void @test_scratch_store(ptr addrspace(5) %ptr, i32 %val) {
-; GCN-LABEL: test_scratch_store:
-; GCN:       ; %bb.0:
-; GCN-NEXT:    s_wait_loadcnt_dscnt 0x0
-; GCN-NEXT:    s_wait_kmcnt 0x0
-; GCN-NEXT:    scratch_store_b32 v0, v1, off
-; GCN-NEXT:    s_set_pc_i64 s[30:31]
-    store i32 %val, ptr addrspace(5) %ptr
-    ret void
-}
-
-define void @test_unknown_flat_store(ptr %ptr, i32 %val) {
-; GCN-LABEL: test_unknown_flat_store:
-; GCN:       ; %bb.0:
-; GCN-NEXT:    s_wait_loadcnt_dscnt 0x0
-; GCN-NEXT:    s_wait_kmcnt 0x0
-; GCN-NEXT:    flat_store_b32 v[0:1], v2
-; GCN-NEXT:    s_wait_dscnt 0x0
-; GCN-NEXT:    s_set_pc_i64 s[30:31]
-    store i32 %val, ptr %ptr
-    ret void
-}
-
-define void @test_flat_store_no_scratch_alloc(ptr %ptr, i32 %val) #0 {
-; GCN-LABEL: test_flat_store_no_scratch_alloc:
-; GCN:       ; %bb.0:
-; GCN-NEXT:    s_wait_loadcnt_dscnt 0x0
-; GCN-NEXT:    s_wait_kmcnt 0x0
-; GCN-NEXT:    flat_store_b32 v[0:1], v2
-; GCN-NEXT:    s_wait_dscnt 0x0
-; GCN-NEXT:    s_set_pc_i64 s[30:31]
-    store i32 %val, ptr %ptr
-    ret void
-}
-
-define void @test_flat_store_noalias_addrspace(ptr %ptr, i32 %val) {
-; GCN-LABEL: test_flat_store_noalias_addrspace:
-; GCN:       ; %bb.0:
-; GCN-NEXT:    s_wait_loadcnt_dscnt 0x0
-; GCN-NEXT:    s_wait_kmcnt 0x0
-; GCN-NEXT:    flat_store_b32 v[0:1], v2
-; GCN-NEXT:    s_wait_dscnt 0x0
-; GCN-NEXT:    s_set_pc_i64 s[30:31]
-    store i32 %val, ptr %ptr, !noalias.addrspace !{i32 5, i32 6}
-    ret void
-}
-
-; TODO: would be nice to handle
-define void @test_flat_store_select(ptr addrspace(1) %a, ptr addrspace(3) %b, i1 %cond, i32 %val) {
-; GCN-SDAG-LABEL: test_flat_store_select:
-; GCN-SDAG:       ; %bb.0:
-; GCN-SDAG-NEXT:    s_wait_loadcnt_dscnt 0x0
-; GCN-SDAG-NEXT:    s_wait_kmcnt 0x0
-; GCN-SDAG-NEXT:    v_cmp_ne_u32_e32 vcc_lo, -1, v2
-; GCN-SDAG-NEXT:    v_and_b32_e32 v3, 1, v3
-; GCN-SDAG-NEXT:    s_mov_b64 s[0:1], src_shared_base
-; GCN-SDAG-NEXT:    v_cndmask_b32_e32 v2, 0, v2, vcc_lo
-; GCN-SDAG-NEXT:    v_cndmask_b32_e64 v5, 0, s1, vcc_lo
-; GCN-SDAG-NEXT:    s_delay_alu instid0(VALU_DEP_3) | instskip(NEXT) | instid1(VALU_DEP_2)
-; GCN-SDAG-NEXT:    v_cmp_eq_u32_e32 vcc_lo, 1, v3
-; GCN-SDAG-NEXT:    v_dual_cndmask_b32 v1, v5, v1 :: v_dual_cndmask_b32 v0, v2, v0
-; GCN-SDAG-NEXT:    flat_store_b32 v[0:1], v4
-; GCN-SDAG-NEXT:    s_wait_dscnt 0x0
-; GCN-SDAG-NEXT:    s_set_pc_i64 s[30:31]
-;
-; GCN-GISEL-LABEL: test_flat_store_select:
-; GCN-GISEL:       ; %bb.0:
-; GCN-GISEL-NEXT:    s_wait_loadcnt_dscnt 0x0
-; GCN-GISEL-NEXT:    s_wait_kmcnt 0x0
-; GCN-GISEL-NEXT:    v_cmp_ne_u32_e32 vcc_lo, -1, v2
-; GCN-GISEL-NEXT:    v_and_b32_e32 v3, 1, v3
-; GCN-GISEL-NEXT:    s_mov_b64 s[0:1], src_shared_base
-; GCN-GISEL-NEXT:    v_cndmask_b32_e32 v2, 0, v2, vcc_lo
-; GCN-GISEL-NEXT:    v_cndmask_b32_e64 v5, 0, s1, vcc_lo
-; GCN-GISEL-NEXT:    s_delay_alu instid0(VALU_DEP_3) | instskip(NEXT) | instid1(VALU_DEP_2)
-; GCN-GISEL-NEXT:    v_cmp_ne_u32_e32 vcc_lo, 0, v3
-; GCN-GISEL-NEXT:    v_dual_cndmask_b32 v0, v2, v0 :: v_dual_cndmask_b32 v1, v5, v1
-; GCN-GISEL-NEXT:    flat_store_b32 v[0:1], v4
-; GCN-GISEL-NEXT:    s_wait_dscnt 0x0
-; GCN-GISEL-NEXT:    s_set_pc_i64 s[30:31]
-    %a.ascast = addrspacecast ptr addrspace(1) %a to ptr
-    %b.ascast = addrspacecast ptr addrspace(3) %b to ptr
-    %ptr = select i1 %cond, ptr %a.ascast, ptr %b.ascast
-    store i32 %val, ptr %ptr
-    ret void
-}
-
-attributes #0 = { "amdgpu-no-flat-scratch-init" }

@rampitec rampitec merged commit 70b150c into main Sep 24, 2025
13 checks passed
@rampitec rampitec deleted the users/rampitec/09-24-_amdgpu_remove_gfx1250-scratch-scope-se.ll._nfc branch September 24, 2025 20:07
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Oct 3, 2025
The test is supposed to check SCOPE_SE upgrade which was
removed and also does not present in the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants