-
Notifications
You must be signed in to change notification settings - Fork 14.8k
[AMDGPU] Remove gfx1250-scratch-scope-se.ll. NFC #160584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rampitec
merged 1 commit into
main
from
users/rampitec/09-24-_amdgpu_remove_gfx1250-scratch-scope-se.ll._nfc
Sep 24, 2025
Merged
[AMDGPU] Remove gfx1250-scratch-scope-se.ll. NFC #160584
rampitec
merged 1 commit into
main
from
users/rampitec/09-24-_amdgpu_remove_gfx1250-scratch-scope-se.ll._nfc
Sep 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is supposed to check SCOPE_SE upgrade which was removed and also does not present in the test.
@llvm/pr-subscribers-backend-amdgpu Author: Stanislav Mekhanoshin (rampitec) ChangesThe test is supposed to check SCOPE_SE upgrade which was Full diff: https://github.com/llvm/llvm-project/pull/160584.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AMDGPU/gfx1250-scratch-scope-se.ll b/llvm/test/CodeGen/AMDGPU/gfx1250-scratch-scope-se.ll
deleted file mode 100644
index f0c9258358316..0000000000000
--- a/llvm/test/CodeGen/AMDGPU/gfx1250-scratch-scope-se.ll
+++ /dev/null
@@ -1,94 +0,0 @@
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
-; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1250 < %s | FileCheck -check-prefixes=GCN,GCN-SDAG %s
-; RUN: llc -global-isel -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1250 < %s | FileCheck -check-prefixes=GCN,GCN-GISEL %s
-
-; Test that stores that may hit scratch are correctly promoted to SCOPE_SE.
-
-define void @test_scratch_store(ptr addrspace(5) %ptr, i32 %val) {
-; GCN-LABEL: test_scratch_store:
-; GCN: ; %bb.0:
-; GCN-NEXT: s_wait_loadcnt_dscnt 0x0
-; GCN-NEXT: s_wait_kmcnt 0x0
-; GCN-NEXT: scratch_store_b32 v0, v1, off
-; GCN-NEXT: s_set_pc_i64 s[30:31]
- store i32 %val, ptr addrspace(5) %ptr
- ret void
-}
-
-define void @test_unknown_flat_store(ptr %ptr, i32 %val) {
-; GCN-LABEL: test_unknown_flat_store:
-; GCN: ; %bb.0:
-; GCN-NEXT: s_wait_loadcnt_dscnt 0x0
-; GCN-NEXT: s_wait_kmcnt 0x0
-; GCN-NEXT: flat_store_b32 v[0:1], v2
-; GCN-NEXT: s_wait_dscnt 0x0
-; GCN-NEXT: s_set_pc_i64 s[30:31]
- store i32 %val, ptr %ptr
- ret void
-}
-
-define void @test_flat_store_no_scratch_alloc(ptr %ptr, i32 %val) #0 {
-; GCN-LABEL: test_flat_store_no_scratch_alloc:
-; GCN: ; %bb.0:
-; GCN-NEXT: s_wait_loadcnt_dscnt 0x0
-; GCN-NEXT: s_wait_kmcnt 0x0
-; GCN-NEXT: flat_store_b32 v[0:1], v2
-; GCN-NEXT: s_wait_dscnt 0x0
-; GCN-NEXT: s_set_pc_i64 s[30:31]
- store i32 %val, ptr %ptr
- ret void
-}
-
-define void @test_flat_store_noalias_addrspace(ptr %ptr, i32 %val) {
-; GCN-LABEL: test_flat_store_noalias_addrspace:
-; GCN: ; %bb.0:
-; GCN-NEXT: s_wait_loadcnt_dscnt 0x0
-; GCN-NEXT: s_wait_kmcnt 0x0
-; GCN-NEXT: flat_store_b32 v[0:1], v2
-; GCN-NEXT: s_wait_dscnt 0x0
-; GCN-NEXT: s_set_pc_i64 s[30:31]
- store i32 %val, ptr %ptr, !noalias.addrspace !{i32 5, i32 6}
- ret void
-}
-
-; TODO: would be nice to handle
-define void @test_flat_store_select(ptr addrspace(1) %a, ptr addrspace(3) %b, i1 %cond, i32 %val) {
-; GCN-SDAG-LABEL: test_flat_store_select:
-; GCN-SDAG: ; %bb.0:
-; GCN-SDAG-NEXT: s_wait_loadcnt_dscnt 0x0
-; GCN-SDAG-NEXT: s_wait_kmcnt 0x0
-; GCN-SDAG-NEXT: v_cmp_ne_u32_e32 vcc_lo, -1, v2
-; GCN-SDAG-NEXT: v_and_b32_e32 v3, 1, v3
-; GCN-SDAG-NEXT: s_mov_b64 s[0:1], src_shared_base
-; GCN-SDAG-NEXT: v_cndmask_b32_e32 v2, 0, v2, vcc_lo
-; GCN-SDAG-NEXT: v_cndmask_b32_e64 v5, 0, s1, vcc_lo
-; GCN-SDAG-NEXT: s_delay_alu instid0(VALU_DEP_3) | instskip(NEXT) | instid1(VALU_DEP_2)
-; GCN-SDAG-NEXT: v_cmp_eq_u32_e32 vcc_lo, 1, v3
-; GCN-SDAG-NEXT: v_dual_cndmask_b32 v1, v5, v1 :: v_dual_cndmask_b32 v0, v2, v0
-; GCN-SDAG-NEXT: flat_store_b32 v[0:1], v4
-; GCN-SDAG-NEXT: s_wait_dscnt 0x0
-; GCN-SDAG-NEXT: s_set_pc_i64 s[30:31]
-;
-; GCN-GISEL-LABEL: test_flat_store_select:
-; GCN-GISEL: ; %bb.0:
-; GCN-GISEL-NEXT: s_wait_loadcnt_dscnt 0x0
-; GCN-GISEL-NEXT: s_wait_kmcnt 0x0
-; GCN-GISEL-NEXT: v_cmp_ne_u32_e32 vcc_lo, -1, v2
-; GCN-GISEL-NEXT: v_and_b32_e32 v3, 1, v3
-; GCN-GISEL-NEXT: s_mov_b64 s[0:1], src_shared_base
-; GCN-GISEL-NEXT: v_cndmask_b32_e32 v2, 0, v2, vcc_lo
-; GCN-GISEL-NEXT: v_cndmask_b32_e64 v5, 0, s1, vcc_lo
-; GCN-GISEL-NEXT: s_delay_alu instid0(VALU_DEP_3) | instskip(NEXT) | instid1(VALU_DEP_2)
-; GCN-GISEL-NEXT: v_cmp_ne_u32_e32 vcc_lo, 0, v3
-; GCN-GISEL-NEXT: v_dual_cndmask_b32 v0, v2, v0 :: v_dual_cndmask_b32 v1, v5, v1
-; GCN-GISEL-NEXT: flat_store_b32 v[0:1], v4
-; GCN-GISEL-NEXT: s_wait_dscnt 0x0
-; GCN-GISEL-NEXT: s_set_pc_i64 s[30:31]
- %a.ascast = addrspacecast ptr addrspace(1) %a to ptr
- %b.ascast = addrspacecast ptr addrspace(3) %b to ptr
- %ptr = select i1 %cond, ptr %a.ascast, ptr %b.ascast
- store i32 %val, ptr %ptr
- ret void
-}
-
-attributes #0 = { "amdgpu-no-flat-scratch-init" }
|
shiltian
approved these changes
Sep 24, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
The test is supposed to check SCOPE_SE upgrade which was removed and also does not present in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is supposed to check SCOPE_SE upgrade which was
removed and also does not present in the test.