Skip to content

Conversation

tbaederr
Copy link
Contributor

The CHECK comment doesn't match the following function name.

The CHECK comment doesn't match the following function name.
@llvmbot
Copy link
Member

llvmbot commented Sep 25, 2025

@llvm/pr-subscribers-mlir

Author: Timm Baeder (tbaederr)

Changes

The CHECK comment doesn't match the following function name.


Full diff: https://github.com/llvm/llvm-project/pull/160651.diff

1 Files Affected:

  • (modified) mlir/test/python/dialects/python_test.py (+1-1)
diff --git a/mlir/test/python/dialects/python_test.py b/mlir/test/python/dialects/python_test.py
index 761d22357f8f8..4a4d763c139a5 100644
--- a/mlir/test/python/dialects/python_test.py
+++ b/mlir/test/python/dialects/python_test.py
@@ -1003,7 +1003,7 @@ def types(lst):
             assert type(op_res_variadic.res) is OpResultList
 
 
-# CHECK-LABEL: TEST: testVariadicAndNormalRegion
+# CHECK-LABEL: TEST: testVariadicAndNormalRegionOp
 @run
 def testVariadicAndNormalRegionOp():
     with Context() as ctx, Location.unknown(ctx):

@tbaederr
Copy link
Contributor Author

This doesn't fix the test failure we're seeing, but it's probably still good for consistency.

@makslevental
Copy link
Contributor

What test failure are you seeing?

@makslevental
Copy link
Contributor

makslevental commented Sep 25, 2025

I saw your question on discord

# .---command stderr------------
# | Traceback (most recent call last):
# |   File "/builddir/build/BUILD/llvm-22.0.0_pre20250925.gba24b3ec6695b2-build/llvm-project-ba24b3ec6695b239366f82968fa78702f6f89da9/mlir/test/python/dialects/python_test.py", line 886, in <module>
# |     @run
# |      ^^^
# |   File "/builddir/build/BUILD/llvm-22.0.0_pre20250925.gba24b3ec6695b2-build/llvm-project-ba24b3ec6695b239366f82968fa78702f6f89da9/mlir/test/python/dialects/python_test.py", line 37, in run
# |     f()
# |     ~^^
# |   File "/builddir/build/BUILD/llvm-22.0.0_pre20250925.gba24b3ec6695b2-build/llvm-project-ba24b3ec6695b239366f82968fa78702f6f89da9/mlir/test/python/dialects/python_test.py", line 906, in testVariadicResultAccess
# |     typing.get_type_hints(test.same_variadic_result_vfv)["return"]
# |     is Union[OpResult, OpResultList, test.SameVariadicResultSizeOpVFV]
# | AssertionError
# `-----------------------------

That check was introduced in this PR #158455 along with the necessary mlir-tblgen code to make it pass. I'm not sure how you could have the assert but not the correct generated code - possibly you need to need do a clean build.

@makslevental
Copy link
Contributor

makslevental commented Sep 25, 2025

full fix here #160718

@tbaederr tbaederr closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants