Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/Func/Transforms/Passes.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class RewritePatternSet;

namespace func {

#define GEN_PASS_DECL_DUPLICATEFUNCTIONELIMINATIONPASS
#define GEN_PASS_DECL
#include "mlir/Dialect/Func/Transforms/Passes.h.inc"

//===----------------------------------------------------------------------===//
Expand Down
8 changes: 8 additions & 0 deletions mlir/include/mlir/Dialect/Func/Transforms/Passes.td
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,12 @@ def DuplicateFunctionEliminationPass : Pass<"duplicate-function-elimination",
}];
}

def EliminateFunctionParameterPass : Pass<"eliminate-function-parameter",
"ModuleOp"> {
let summary = "Eliminate function parameter";
let description = [{
Eliminate function parameter is used to remove unnecessary parameters passed
to a function, then update the function call.
}];
}
#endif // MLIR_DIALECT_FUNC_TRANSFORMS_PASSES_TD
1 change: 1 addition & 0 deletions mlir/lib/Dialect/Func/Transforms/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
add_mlir_dialect_library(MLIRFuncTransforms
EliminateFunctionParameter.cpp
DuplicateFunctionElimination.cpp
FuncConversions.cpp

Expand Down
88 changes: 88 additions & 0 deletions mlir/lib/Dialect/Func/Transforms/EliminateFunctionParameter.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
//===- EliminateFunctionParameter.cpp.cpp - Eliminate function Parameter --===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#include "mlir/Dialect/Func/IR/FuncOps.h"
#include "mlir/Dialect/Func/Transforms/Passes.h"

namespace mlir {
namespace func {
#define GEN_PASS_DEF_ELIMINATEFUNCTIONPARAMETERPASS
#include "mlir/Dialect/Func/Transforms/Passes.h.inc"
} // namespace func

/// This function eliminates unnecessary parameters within the function.
static LogicalResult updateFunc(func::FuncOp funcOp, BitVector &arguemntNoUse) {
Block &entryBlock = funcOp.front();
bool change = false;
FunctionType origType = funcOp.getFunctionType();
llvm::ArrayRef<Type> origInputTypes = origType.getInputs();
SmallVector<Type, 4> newInputTypes;
for (auto iter : llvm::enumerate(funcOp.getArguments())) {
size_t position = iter.index();
if (!iter.value().use_empty()) {
newInputTypes.push_back(origInputTypes[position]);
continue;
}
arguemntNoUse.set(position);
entryBlock.eraseArgument(position);
change = true;
}

if (change) {
auto newFunctionType = FunctionType::get(funcOp.getContext(), newInputTypes,
origType.getResults());
funcOp.setFunctionType(newFunctionType);
}
return success(change);
}

/// After eliminating redundant parameters from the function, update the
/// function calls.
static LogicalResult updateCall(func::CallOp callOp,
BitVector &argumentsNoUse) {
ValueRange origOperands = callOp.getOperands();
SmallVector<Value, 4> newOperands;
for (auto iter : llvm::enumerate(origOperands)) {
if (!argumentsNoUse[iter.index()])
newOperands.push_back(iter.value());
}
callOp->setOperands(newOperands);
return success();
}

namespace {
struct EliminateFunctionParameterPass
: public func::impl::EliminateFunctionParameterPassBase<
EliminateFunctionParameterPass> {
using EliminateFunctionParameterPassBase<
EliminateFunctionParameterPass>::EliminateFunctionParameterPassBase;
void runOnOperation() override {
ModuleOp moduleOp = getOperation();
for (auto funcOp : moduleOp.getOps<func::FuncOp>()) {
size_t argumentSize = funcOp.getArguments().size();
if (!argumentSize)
continue;
BitVector argumentNoUse(argumentSize);
if (failed(updateFunc(funcOp, argumentNoUse)))
continue;

auto symbolOp = mlir::cast<SymbolOpInterface>(funcOp.getOperation());
auto users = symbolOp.getSymbolUses(moduleOp);

if (!users.has_value())
continue;
for (SymbolTable::SymbolUse user : *users) {
Operation *call = user.getUser();
(void)updateCall(mlir::cast<func::CallOp>(call), argumentNoUse);
}
}
}
};

} // namespace
} // namespace mlir
32 changes: 32 additions & 0 deletions mlir/test/Dialect/Func/eliminate-function-parameter.mlir
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// RUN: mlir-opt %s --split-input-file --eliminate-function-parameter | \
// RUN: FileCheck %s

func.func @single_parameter(%arg: index) {
return
}

func.func @mutl_parameter(%arg0 : index, %arg1 : index) -> index {
return %arg0 : index
}

func.func @eliminate_parameter(%arg0: index, %arg1: index) -> index {
func.call @single_parameter(%arg0) : (index) -> ()
%ret = func.call @mutl_parameter(%arg0, %arg0) : (index, index) -> (index)
return %ret : index
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: all these functions are public, it is incorrect to change the signature of a public function: you can't know about call sites outside of the current module.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I hadn't considered.Thank you for the reminder. It has helped me better understand the meaning of “public function.”


// CHECK-LABEL: func @single_parameter() {
// CHECK: return
// CHECK: }

// CHECK-LABEL: func @mutl_parameter(
// CHECK-SAME: %[[ARG0:.*]]: index) -> index {
// CHECK: return %[[ARG0]] : index
// CHECK: }

// CHECK-LABEL: func @eliminate_parameter(
// CHECK-SAME: %[[ARG0:.*]]: index) -> index {
// CHECK: call @single_parameter() : () -> ()
// CHECK: %[[RET:.*]] = call @mutl_parameter(%[[ARG0]]) : (index) -> index
// CHECK: return %[[RET]] : index
// CHECK: }