Skip to content

[WIP][mlir][Bufferization] Accelerate bufferization pass #160655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP][mlir][Bufferization] Accelerate bufferization pass #160655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae4245
[mlir][Bufferization] Accelerate bufferization pass
mingzheTerapines Sep 25, 2025
7869225
put code to lambda and check in debug build
mingzheTerapines Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,9 @@ class AnalysisState {
/// regions.
DenseMap<std::pair<Operation *, Operation *>, bool>
insideMutuallyExclusiveRegionsCache;

/// Cache for getAliasingOpOperands results to avoid expensive recomputation.
mutable DenseMap<Value, AliasingOpOperandList> aliasingOpOperandsCache;
};

/// BufferizationState provides information about the state of the IR during the
Expand Down
34 changes: 29 additions & 5 deletions mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ bool AnalysisState::insideMutuallyExclusiveRegions(Operation *op0,
void AnalysisState::resetCache() {
enclosingRepetitiveRegionCache.clear();
insideMutuallyExclusiveRegionsCache.clear();
aliasingOpOperandsCache.clear();
}

SymbolTableCollection &BufferizationState::getSymbolTables() {
Expand Down Expand Up @@ -413,12 +414,35 @@ static void setInsertionPointAfter(OpBuilder &b, Value value) {
/// Determine which OpOperand* will alias with `value` if the op is bufferized
/// in place. Return all tensor OpOperand* if the op is not bufferizable.
AliasingOpOperandList AnalysisState::getAliasingOpOperands(Value value) const {
if (Operation *op = getOwnerOfValue(value))
if (auto bufferizableOp = getOptions().dynCastBufferizableOp(op))
return bufferizableOp.getAliasingOpOperands(value, *this);
// Lambda to compute aliasing operands
auto computeAliasingOpOperands = [&]() -> AliasingOpOperandList {
AliasingOpOperandList result;
if (Operation *op = getOwnerOfValue(value))
if (auto bufferizableOp = getOptions().dynCastBufferizableOp(op))
result = bufferizableOp.getAliasingOpOperands(value, *this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just write return bufferizableOp.getAliasingOpOperands(value, *this); here and return ... at the end of the function.

else
// The op is not bufferizable.
result = detail::unknownGetAliasingOpOperands(value);
else
// The op is not bufferizable.
result = detail::unknownGetAliasingOpOperands(value);
return result;
};

// The op is not bufferizable.
return detail::unknownGetAliasingOpOperands(value);
// Check cache first
auto it = aliasingOpOperandsCache.find(value);
if (it != aliasingOpOperandsCache.end()) {
#ifndef NDEBUG
assert(it->second == computeAliasingOpOperands() &&
"inconsistent cache result");
#endif // NDEBUG
return it->second;
}

// Cache the result
AliasingOpOperandList result = computeAliasingOpOperands();
aliasingOpOperandsCache[value] = result;
return result;
}

/// Determine which Values will alias with `opOperand` if the op is bufferized
Expand Down