Skip to content

[libc++] Remove string external instantiations that just call _Traits::length #160673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[libc++] Remove string external instantiations that just call _Traits::length #160673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions libcxx/include/__string/extern_template_lists.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,13 @@
Func(basic_string<CharT>& basic_string<CharT>::assign(size_type, value_type)) \
Func(basic_string<CharT>& basic_string<CharT>::assign(const basic_string&, size_type, size_type)) \
Func(basic_string<CharT>& basic_string<CharT>::append(size_type, value_type)) \
Func(basic_string<CharT>& basic_string<CharT>::append(const value_type*)) \
Func(basic_string<CharT>& basic_string<CharT>::append(const value_type*, size_type)) \
Func(basic_string<CharT>& basic_string<CharT>::append(const basic_string&, size_type, size_type)) \
Func(void basic_string<CharT>::push_back(value_type)) \
Func(basic_string<CharT>& basic_string<CharT>::insert(size_type, const value_type*)) \
Func(basic_string<CharT>& basic_string<CharT>::insert(size_type, size_type, value_type)) \
Func(basic_string<CharT>& basic_string<CharT>::insert(size_type, const value_type*, size_type)) \
Func(basic_string<CharT>& basic_string<CharT>::insert(size_type, const basic_string&, size_type, size_type)) \
Func(basic_string<CharT>::iterator basic_string<CharT>::insert(basic_string::const_iterator, value_type)) \
Func(basic_string<CharT>& basic_string<CharT>::replace(size_type, size_type, const value_type*)) \
Func(basic_string<CharT>& basic_string<CharT>::replace(size_type, size_type, size_type, value_type)) \
Func(basic_string<CharT>& basic_string<CharT>::replace(size_type, size_type, const value_type*, size_type)) \
Func(basic_string<CharT>& basic_string<CharT>::replace(size_type, size_type, const basic_string&, size_type, size_type)) \
Expand All @@ -64,8 +61,6 @@
Func(basic_string<CharT>::size_type basic_string<CharT>::find_last_not_of(const value_type*, size_type, size_type) const) \
Func(CharT& basic_string<CharT>::at(size_type)) \
Func(const CharT& basic_string<CharT>::at(size_type) const) \
Func(int basic_string<CharT>::compare(const value_type*) const) \
Func(int basic_string<CharT>::compare(size_type, size_type, const value_type*) const) \
Func(int basic_string<CharT>::compare(size_type, size_type, const value_type*, size_type) const) \
Func(int basic_string<CharT>::compare(size_type, size_type, const basic_string&, size_type, size_type) const) \
Func(const basic_string<CharT>::size_type basic_string<CharT>::npos) \
Expand All @@ -74,7 +69,6 @@
_LIBCPP_STRING_COMMON_EXTERN_TEMPLATE_LIST(Func, CharT) \
Func(basic_string<CharT>::basic_string(const basic_string&)) \
Func(basic_string<CharT>::basic_string(const basic_string&, const allocator<CharT>&)) \
Func(basic_string<CharT>& basic_string<CharT>::assign(const value_type*)) \
Func(basic_string<CharT>& basic_string<CharT>::assign(const value_type*, size_type)) \
Func(basic_string<CharT>& basic_string<CharT>::operator=(basic_string const&)) \
Func(void basic_string<CharT>::__grow_by(size_type, size_type, size_type, size_type, size_type, size_type)) \
Expand All @@ -84,7 +78,6 @@
_LIBCPP_STRING_COMMON_EXTERN_TEMPLATE_LIST(Func, CharT) \
Func(void basic_string<CharT>::__init_copy_ctor_external(const value_type*, size_type)) \
Func(basic_string<CharT>& basic_string<CharT>::__assign_external(const value_type*, size_type)) \
Func(basic_string<CharT>& basic_string<CharT>::__assign_external(const value_type*)) \
Func(basic_string<CharT>& basic_string<CharT>::__assign_no_alias<false>(const value_type*, size_type)) \
Func(basic_string<CharT>& basic_string<CharT>::__assign_no_alias<true>(const value_type*, size_type)) \
Func(void basic_string<CharT>::__erase_external_with_move(size_type, size_type))
Expand Down
10 changes: 9 additions & 1 deletion libcxx/src/string.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,15 @@ void basic_string<_CharT, _Traits, _Allocator>::__init(const value_type* __s, si
}

# define STRING_LEGACY_API(CharT) \
template _LIBCPP_EXPORTED_FROM_ABI void basic_string<CharT>::__init(const value_type*, size_type, size_type)
template _LIBCPP_EXPORTED_FROM_ABI void basic_string<CharT>::__init(const value_type*, size_type, size_type); \
template _LIBCPP_EXPORTED_FROM_ABI basic_string<CharT>& basic_string<CharT>::append(const value_type*); \
template _LIBCPP_EXPORTED_FROM_ABI basic_string<CharT>& basic_string<CharT>::insert(size_type, const value_type*); \
template _LIBCPP_EXPORTED_FROM_ABI basic_string<CharT>& basic_string<CharT>::replace( \
size_type, size_type, const value_type*); \
template _LIBCPP_EXPORTED_FROM_ABI int basic_string<CharT>::compare(const value_type*) const; \
template _LIBCPP_EXPORTED_FROM_ABI int basic_string<CharT>::compare(size_type, size_type, const value_type*) \
const; \
template _LIBCPP_EXPORTED_FROM_ABI basic_string<CharT>& basic_string<CharT>::assign(const value_type*)

STRING_LEGACY_API(char);
# if _LIBCPP_HAS_WIDE_CHARACTERS
Expand Down
Loading