Skip to content

[SDAG] Use useDebugInstrRef instead of shouldUseDebugInstrRef #160686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 8, 2025
Merged

[SDAG] Use useDebugInstrRef instead of shouldUseDebugInstrRef #160686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d73e3a7
Use useDebugInstrRef instead of shouldUseDebugInstrRef
mikolaj-pirog Sep 25, 2025
fc4e588
Merge remote-tracking branch 'origin/main' into mpirog/fix-wrong-inst…
mikolaj-pirog Sep 30, 2025
5b69ca6
Merge remote-tracking branch 'other/main' into mpirog/fix-wrong-instr…
mikolaj-pirog Sep 30, 2025
1c7ada8
Merge remote-tracking branch 'other/main' into mpirog/fix-wrong-instr…
mikolaj-pirog Oct 7, 2025
fb7dd26
Add test
mikolaj-pirog Oct 7, 2025
57c39f4
Fix test
mikolaj-pirog Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ bool SelectionDAGISel::runOnMachineFunction(MachineFunction &mf) {
SwiftError->setFunction(mf);
const Function &Fn = mf.getFunction();

bool InstrRef = mf.shouldUseDebugInstrRef();
bool InstrRef = mf.useDebugInstrRef();

FuncInfo->set(MF->getFunction(), *MF, CurDAG);

Expand Down
36 changes: 36 additions & 0 deletions llvm/test/DebugInfo/X86/instr-ref-opt-bisect2.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
; RUN: llc %s -o - -stop-after=livedebugvalues -opt-bisect-limit=1 | FileCheck %s
; RUN: llc %s -o - -stop-after=livedebugvalues -opt-bisect-limit=10 | FileCheck %s
; RUN: llc %s -o - -stop-after=livedebugvalues -opt-bisect-limit=100 | FileCheck %s

; RUN: llc %s -o - -stop-after=livedebugvalues -opt-bisect-limit=1 -fast-isel=true | FileCheck %s
; RUN: llc %s -o - -stop-after=livedebugvalues -opt-bisect-limit=10 -fast-isel=true | FileCheck %s
; RUN: llc %s -o - -stop-after=livedebugvalues -opt-bisect-limit=100 -fast-isel=true | FileCheck %s

; This test has the same purpose as the instr-ref-opt-bisect.ll, to check if
; during opt-bisect's optimisation level change we won't run into an assert.
; This is simply testing different IR.

; CHECK: DBG_VALUE

target triple = "x86_64-pc-windows-msvc"

define i1 @foo(i32 %arg) !dbg !3 {
entry:
#dbg_value(i32 %arg, !4, !DIExpression(), !5)
switch i32 %arg, label %bb [
i32 810, label %bb
], !dbg !5
bb:
%a = load volatile i1, ptr null, align 1
ret i1 false
}

!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!2}

!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !1)
!1 = !DIFile(filename: "instr-ref-opt-bisect2.ll", directory: ".")
!2 = !{i32 2, !"Debug Info Version", i32 3}
!3 = distinct !DISubprogram(name: "instr-ref-opt-bisect2", file: !1, unit: !0)
!4 = !DILocalVariable(name: "arg", arg: 2, scope: !3)
!5 = !DILocation(line: 0, scope: !3)