Skip to content

[mlir][scf] ExecuteRegionOp bufferization to consider no_inline attr #160697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 25, 2025
+16 −2
Merged

[mlir][scf] ExecuteRegionOp bufferization to consider no_inline attr #160697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbbd38f
[mlir][scf] ExecuteRegionOp bufferization to consider no_inline attri…
dorAradME Sep 25, 2025
cd3fcbe
Merge branch 'main' into undor/execute_region_bufferize_no_inline
undor Sep 25, 2025
55a4b7a
Merge branch 'main' into undor/execute_region_bufferize_no_inline
undor Sep 25, 2025
187e3e6
Merge branch 'main' into undor/execute_region_bufferize_no_inline
undor Sep 25, 2025
fa9e04c
Merge branch 'main' into undor/execute_region_bufferize_no_inline
undor Sep 25, 2025
9484af0
Merge branch 'llvm:main' into undor/execute_region_bufferize_no_inline
undor Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlir/lib/Dialect/SCF/Transforms/BufferizableOpInterfaceImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ struct ExecuteRegionOpInterface
TypeRange newResultTypes(yieldOp.getResults());

// Create new op and move over region.
auto newOp =
scf::ExecuteRegionOp::create(rewriter, op->getLoc(), newResultTypes);
auto newOp = scf::ExecuteRegionOp::create(
rewriter, op->getLoc(), newResultTypes, executeRegionOp.getNoInline());
newOp.getRegion().takeBody(executeRegionOp.getRegion());

// Bufferize every block.
Expand Down
14 changes: 14 additions & 0 deletions mlir/test/Dialect/Bufferization/Transforms/one-shot-module-bufferize.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,20 @@ func.func @execute_region_test(%t1 : tensor<?xf32>)

// -----

// CHECK-LABEL: func @no_inline_execute_region_not_canonicalized
func.func @no_inline_execute_region_not_canonicalized() {
%c = arith.constant 42 : i32
// CHECK: scf.execute_region
// CHECK-SAME: no_inline
%v = scf.execute_region -> i32 no_inline {
scf.yield %c : i32
}
// CHECK: return
return
}

// -----

// CHECK: func private @some_external_func(memref<?xf32, strided<[?], offset: ?>>)
func.func private @some_external_func(tensor<?xf32>)

Expand Down