Revert changes to llvm-string stdin test and XFAIL on AIX

[madanial0]

Xfail testcase on AIX until echo -n bug is fixed, revert changes made to testcase

[llvmbot]

@llvm/pr-subscribers-llvm-binary-utilities

Author: Mark Danial (madanial0)

Changes

Xfail testcase on AIX until echo -n bug is fixed, revert changes made to testcase

---

Full diff: https://github.com/llvm/llvm-project/pull/160821.diff

1 Files Affected:

• (modified) llvm/test/tools/llvm-strings/stdin.test (+5-6)

diff --git a/llvm/test/tools/llvm-strings/stdin.test b/llvm/test/tools/llvm-strings/stdin.test
index 3c60123ca8921..ef6cd131f5879 100644
--- a/llvm/test/tools/llvm-strings/stdin.test
+++ b/llvm/test/tools/llvm-strings/stdin.test
@@ -1,13 +1,13 @@
+; XFAIL: target={{.*}}-aix{{.*}}
+
 ## Show that llvm-strings can handle stdin input properly.
 
 ## Case 1: output with single string.
-RUN: echo -n "abcdefg" > %t
-RUN: llvm-strings %t - | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}}
+RUN: echo -n "abcdefg" | llvm-strings - | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}}
 CASE1: abcdefg
 
 ## Case 2: output too short for string.
-RUN: echo -n "abc" > %t
-RUN: llvm-strings %t - | FileCheck %s --implicit-check-not={{.}} --allow-empty
+RUN: echo -n "abc" | llvm-strings - | FileCheck %s --implicit-check-not={{.}} --allow-empty
 
 ## Case 3: output with new line.
 RUN: printf "abcd\nefgh" | llvm-strings - | FileCheck %s --check-prefix=CASE3 --implicit-check-not={{.}}
@@ -21,5 +21,4 @@ CASE4-NEXT: ghij
 CASE4-NEXT: klmn
 
 ## Case 5: no file name specified is equivalent to explicitly requesting stdin.
-RUN: echo -n "abcdefg" > %t
-RUN: llvm-strings %t - | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}}
+RUN: echo -n "abcdefg" | llvm-strings | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}}

[jh7370]

This isn't correct. It'll XFAIL the test if the AIX target is enabled, when it should be when the host system is AIX.

[jh7370]

LGTM, but really the lit behaviour should be fixed.

[llvm-ci]

LLVM Buildbot has detected a new failure on builder llvm-nvptx64-nvidia-win running on as-builder-8 while building llvm at step 7 "test-build-unified-tree-check-llvm".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/155/builds/13353

Here is the relevant piece of the build log for the reference

Step 7 (test-build-unified-tree-check-llvm) failure: test (failure)
******************** TEST 'LLVM-Unit :: Support/./SupportTests.exe/74/103' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\build\unittests\Support\.\SupportTests.exe-LLVM-Unit-5668-74-103.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=103 GTEST_SHARD_INDEX=74 C:\buildbot\as-builder-8\llvm-nvptx64-nvidia-win\build\unittests\Support\.\SupportTests.exe
--


Note: This is test shard 75 of 103.

[==========] Running 16 tests from 16 test suites.

[----------] Global test environment set-up.

[----------] 1 test from Base64Test

[ RUN      ] Base64Test.Base64

[       OK ] Base64Test.Base64 (0 ms)

[----------] 1 test from Base64Test (0 ms total)



[----------] 1 test from CommandLineTest

[ RUN      ] CommandLineTest.TokenizeGNUCommandLine

[       OK ] CommandLineTest.TokenizeGNUCommandLine (0 ms)

[----------] 1 test from CommandLineTest (0 ms total)



[----------] 1 test from FPUNumberModule

[ RUN      ] FPUNumberModule.testAttribute

[       OK ] FPUNumberModule.testAttribute (0 ms)

[----------] 1 test from FPUNumberModule (0 ms total)



[----------] 1 test from Error

[ RUN      ] Error.HasValueMatcher

[       OK ] Error.HasValueMatcher (0 ms)

[----------] 1 test from Error (0 ms total)
...