[BOLT][AArch64] Fix BUILD_SHARED_LIBS after #158738 #160854
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link BOLTUtils against the AArch64 target to support the new option that enables instrumentation without LSE (see #158738) This fixes shared library builds, eg: https://lab.llvm.org/staging/#/builders/220/builds/1537 Note: the link points to a collapsing builder.
paschalis-mpeis
requested review from
aaupov,
maksfb,
rafaelauler,
ayermolo,
yota9 and
yozhu
as code owners
|
@llvm/pr-subscribers-bolt Author: Paschalis Mpeis (paschalis-mpeis) ChangesLink BOLTUtils against the AArch64 target to support the new option This fixes shared library builds, eg: Note: the link points to a collapsing builder. Full diff: https://github.com/llvm/llvm-project/pull/160854.diff 1 Files Affected:
diff --git a/bolt/lib/Target/AArch64/CMakeLists.txt b/bolt/lib/Target/AArch64/CMakeLists.txt
index cb38117de659e..53554e75de15c 100644
--- a/bolt/lib/Target/AArch64/CMakeLists.txt
+++ b/bolt/lib/Target/AArch64/CMakeLists.txt
@@ -28,7 +28,7 @@ add_llvm_library(LLVMBOLTTargetAArch64
AArch64CommonTableGen
)
-target_link_libraries(LLVMBOLTTargetAArch64 PRIVATE LLVMBOLTCore)
+target_link_libraries(LLVMBOLTTargetAArch64 PRIVATE LLVMBOLTCore LLVMBOLTUtils)
include_directories(
${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64
|
yozhu
approved these changes
Sep 26, 2025
|
No worries and thanks for your improving AArch64! |
paschalis-mpeis
deleted the
users/paschalis-mpeis/fix-aarch64-shared-build
branch
YixingZhang007
pushed a commit
to YixingZhang007/llvm-project
that referenced
this pull request
Sep 27, 2025
Link BOLTUtils against the AArch64 target to support the new option that enables instrumentation without LSE (see llvm#158738) This fixes shared library builds, eg: https://lab.llvm.org/staging/#/builders/220/builds/1537 Note: the link points to a collapsing builder.
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
Link BOLTUtils against the AArch64 target to support the new option that enables instrumentation without LSE (see llvm#158738) This fixes shared library builds, eg: https://lab.llvm.org/staging/#/builders/220/builds/1537 Note: the link points to a collapsing builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link BOLTUtils against the AArch64 target to support the new option
that enables instrumentation without LSE (see #158738)
This fixes shared library builds, eg:
https://lab.llvm.org/staging/#/builders/220/builds/1537
Note: the link points to a collapsing builder.