Skip to content

[ADT] Use structured bindings in CoalescingBitVector.h (NFC) #160976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2025
Merged

[ADT] Use structured bindings in CoalescingBitVector.h (NFC) #160976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions llvm/include/llvm/ADT/CoalescingBitVector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,7 @@ template <typename IndexT> class CoalescingBitVector {

// Delete the overlapping intervals. Split up intervals that only partially
// intersect an overlap.
for (IntervalT Overlap : Overlaps) {
IndexT OlapStart, OlapStop;
std::tie(OlapStart, OlapStop) = Overlap;

for (auto [OlapStart, OlapStop] : Overlaps) {
auto It = Intervals.find(OlapStart);
IndexT CurrStart = It.start();
IndexT CurrStop = It.stop();
Expand Down Expand Up @@ -420,10 +417,7 @@ template <typename IndexT> class CoalescingBitVector {
const SmallVectorImpl<IntervalT> &Overlaps,
SmallVectorImpl<IntervalT> &NonOverlappingParts) {
IndexT NextUncoveredBit = Start;
for (IntervalT Overlap : Overlaps) {
IndexT OlapStart, OlapStop;
std::tie(OlapStart, OlapStop) = Overlap;

for (auto [OlapStart, OlapStop] : Overlaps) {
// [Start;Stop] and [OlapStart;OlapStop] overlap iff OlapStart <= Stop
// and Start <= OlapStop.
bool DoesOverlap = OlapStart <= Stop && Start <= OlapStop;
Expand Down