Skip to content

[ADT] Consolidate assertSafeToReferenceAfterClear with "if constexpr" (NFC) #161042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2025
Merged

[ADT] Consolidate assertSafeToReferenceAfterClear with "if constexpr" (NFC) #161042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions llvm/include/llvm/ADT/SmallVector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,17 +199,18 @@ class SmallVectorTemplateCommon
}

/// Check whether any part of the range will be invalidated by clearing.
void assertSafeToReferenceAfterClear(const T *From, const T *To) {
if (From == To)
return;
this->assertSafeToReferenceAfterResize(From, 0);
this->assertSafeToReferenceAfterResize(To - 1, 0);
}
template <
class ItTy,
std::enable_if_t<!std::is_same<std::remove_const_t<ItTy>, T *>::value,
bool> = false>
void assertSafeToReferenceAfterClear(ItTy, ItTy) {}
template <class ItTy>
void assertSafeToReferenceAfterClear(ItTy From, ItTy To) {
if constexpr (std::is_pointer_v<ItTy> &&
std::is_same_v<
std::remove_const_t<std::remove_pointer_t<ItTy>>,
std::remove_const_t<T>>) {
if (From == To)
return;
this->assertSafeToReferenceAfterResize(From, 0);
this->assertSafeToReferenceAfterResize(To - 1, 0);
}
}

/// Check whether any part of the range will be invalidated by growing.
template <class ItTy> void assertSafeToAddRange(ItTy From, ItTy To) {
Expand Down
Loading