Skip to content

[clang][Diags] Automatically format AP(S)Int values with separators #161047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

[clang][Diags] Automatically format AP(S)Int values with separators #161047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions clang/include/clang/Basic/Diagnostic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "llvm/ADT/IntrusiveRefCntPtr.h"
#include "llvm/ADT/SmallString.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/ADT/iterator_range.h"
#include "llvm/Support/Compiler.h"
#include <cassert>
Expand Down Expand Up @@ -1366,6 +1367,22 @@ inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
return DB;
}

inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
const llvm::APSInt &Int) {
DB.AddString(toString(Int, /*Radix=*/10, Int.isSigned(),
/*formatAsCLiteral=*/false,
/*UpperCase=*/true, /*InsertSeparators=*/true));
return DB;
}

inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
const llvm::APInt &Int) {
DB.AddString(toString(Int, /*Radix=*/10, /*Signed=*/false,
/*formatAsCLiteral=*/false,
/*UpperCase=*/true, /*InsertSeparators=*/true));
return DB;
}

inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
int I) {
DB.AddTaggedVal(I, DiagnosticsEngine::ak_sint);
Expand Down
3 changes: 1 addition & 2 deletions clang/lib/Sema/SemaDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18909,8 +18909,7 @@ ExprResult Sema::VerifyBitField(SourceLocation FieldLoc,
// 'bool'.
if (BitfieldIsOverwide && !FieldTy->isBooleanType() && FieldName) {
Diag(FieldLoc, diag::warn_bitfield_width_exceeds_type_width)
<< FieldName << toString(Value, 10)
<< (unsigned)TypeWidth;
<< FieldName << Value << (unsigned)TypeWidth;
}
}

Expand Down
2 changes: 1 addition & 1 deletion clang/test/SemaCXX/bitfield-layout.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ CHECK_SIZE(Test4, 8);
CHECK_ALIGN(Test4, 8);

struct Test5 {
char c : 0x100000001; // expected-warning {{width of bit-field 'c' (4294967297 bits) exceeds the width of its type; value will be truncated to 8 bits}}
char c : 0x100000001; // expected-warning {{width of bit-field 'c' (4'294'967'297 bits) exceeds the width of its type; value will be truncated to 8 bits}}
};
// Size and align don't really matter here, just make sure we don't crash.
CHECK_SIZE(Test5, 1);
Expand Down