Skip to content

Conversation

boomanaiden154
Copy link
Contributor

This was included in the v21 release, so we can reasonably remove it now. Add a TODO for the other functions that have not yet made it into a release. It does not cost much to keep them around until the next release given the small amount of code and should give a little bit of extra time for some downstreams to migrate.

This was included in the v21 release, so we can reasonably remove it
now. Add a TODO for the other functions that have not yet made it into a
release. It does not cost much to keep them around until the next
release given the small amount of code and should give a little bit of
extra time for some downstreams to migrate.
@boomanaiden154 boomanaiden154 force-pushed the remove-deprecated-string-triples branch from 32eaa6c to 13f984f Compare September 28, 2025 06:36
@boomanaiden154
Copy link
Contributor Author

boomanaiden154 commented Sep 28, 2025

@boomanaiden154 boomanaiden154 marked this pull request as ready for review October 4, 2025 19:14
@boomanaiden154 boomanaiden154 requested review from arsenm and nikic October 4, 2025 19:14
@llvmbot llvmbot added the llvm:mc Machine (object) code label Oct 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 4, 2025

@llvm/pr-subscribers-llvm-mc

Author: Aiden Grossman (boomanaiden154)

Changes

This was included in the v21 release, so we can reasonably remove it now. Add a TODO for the other functions that have not yet made it into a release. It does not cost much to keep them around until the next release given the small amount of code and should give a little bit of extra time for some downstreams to migrate.


Full diff: https://github.com/llvm/llvm-project/pull/161053.diff

1 Files Affected:

  • (modified) llvm/include/llvm/MC/TargetRegistry.h (+5-10)
diff --git a/llvm/include/llvm/MC/TargetRegistry.h b/llvm/include/llvm/MC/TargetRegistry.h
index 019ee602975f7..570d4c0e8d272 100644
--- a/llvm/include/llvm/MC/TargetRegistry.h
+++ b/llvm/include/llvm/MC/TargetRegistry.h
@@ -389,6 +389,7 @@ class Target {
   /// @name Feature Constructors
   /// @{
 
+  // TODO(boomanaiden154): Remove this function after LLVM 22 branches.
   [[deprecated("Use overload accepting Triple instead")]]
   MCAsmInfo *createMCAsmInfo(const MCRegisterInfo &MRI, StringRef TheTriple,
                              const MCTargetOptions &Options) const {
@@ -440,6 +441,7 @@ class Target {
     return MCInstrAnalysisCtorFn(Info);
   }
 
+  // TODO(boomanaiden154): Remove this function after LLVM 22 branches.
   [[deprecated("Use overload accepting Triple instead")]]
   MCRegisterInfo *createMCRegInfo(StringRef TT) const {
     if (!MCRegInfoCtorFn)
@@ -454,6 +456,7 @@ class Target {
     return MCRegInfoCtorFn(TT);
   }
 
+  // TODO(boomanaiden154): Remove this function after LLVM 22 branches.
   [[deprecated("Use overload accepting Triple instead")]]
   MCSubtargetInfo *createMCSubtargetInfo(StringRef TheTriple, StringRef CPU,
                                          StringRef Features) const {
@@ -496,16 +499,6 @@ class Target {
                                JIT);
   }
 
-  [[deprecated("Use overload accepting Triple instead")]]
-  TargetMachine *createTargetMachine(
-      StringRef TT, StringRef CPU, StringRef Features,
-      const TargetOptions &Options, std::optional<Reloc::Model> RM,
-      std::optional<CodeModel::Model> CM = std::nullopt,
-      CodeGenOptLevel OL = CodeGenOptLevel::Default, bool JIT = false) const {
-    return createTargetMachine(Triple(TT), CPU, Features, Options, RM, CM, OL,
-                               JIT);
-  }
-
   /// createMCAsmBackend - Create a target specific assembly parser.
   MCAsmBackend *createMCAsmBackend(const MCSubtargetInfo &STI,
                                    const MCRegisterInfo &MRI,
@@ -599,6 +592,7 @@ class Target {
     return nullptr;
   }
 
+  // TODO(boomanaiden154): Remove this function after LLVM 22 branches.
   [[deprecated("Use overload accepting Triple instead")]]
   MCRelocationInfo *createMCRelocationInfo(StringRef TT, MCContext &Ctx) const {
     return createMCRelocationInfo(Triple(TT), Ctx);
@@ -616,6 +610,7 @@ class Target {
     return Fn(TT, Ctx);
   }
 
+  // TODO(boomanaiden154): Remove this function after LLVM 22 branches.
   [[deprecated("Use overload accepting Triple instead")]]
   MCSymbolizer *
   createMCSymbolizer(StringRef TT, LLVMOpInfoCallback GetOpInfo,

@boomanaiden154 boomanaiden154 enabled auto-merge (squash) October 4, 2025 19:18
@boomanaiden154 boomanaiden154 merged commit cc127f0 into llvm:main Oct 4, 2025
10 checks passed
@boomanaiden154 boomanaiden154 deleted the remove-deprecated-string-triples branch October 4, 2025 19:54
aokblast pushed a commit to aokblast/llvm-project that referenced this pull request Oct 6, 2025
This was included in the v21 release, so we can reasonably remove it
now. Add a TODO for the other functions that have not yet made it into a
release. It does not cost much to keep them around until the next
release given the small amount of code and should give a little bit of
extra time for some downstreams to migrate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:mc Machine (object) code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants