-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[Docs][RISCV]Remove experimental from Smctr, Ssctr,Sdext and Sdtrig #161058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-backend-risc-v Author: Liao Chunyu (ChunyuLiao) ChangesFull diff: https://github.com/llvm/llvm-project/pull/161058.diff 1 Files Affected:
diff --git a/llvm/docs/RISCVUsage.rst b/llvm/docs/RISCVUsage.rst
index 7b1a6ce834919..d3c62c1b0d821 100644
--- a/llvm/docs/RISCVUsage.rst
+++ b/llvm/docs/RISCVUsage.rst
@@ -120,6 +120,8 @@ on support follow.
``H`` Assembly Support
``M`` Supported
``Q`` Assembly Support
+ ``Sdext`` Assembly Support
+ ``Sdtrig`` Assembly Support
``Sha`` Supported
``Shcounterenw`` Assembly Support (`See note <#riscv-profiles-extensions-note>`__)
``Shgatpa`` Assembly Support (`See note <#riscv-profiles-extensions-note>`__)
@@ -132,6 +134,7 @@ on support follow.
``Smcdeleg`` Supported
``Smcntrpmf`` Supported
``Smcsrind`` Supported
+ ``Smctr`` Assembly Support
``Smdbltrp`` Supported
``Smepmp`` Supported
``Smmpm`` Supported
@@ -144,6 +147,7 @@ on support follow.
``Sscofpmf`` Assembly Support
``Sscounterenw`` Assembly Support (`See note <#riscv-profiles-extensions-note>`__)
``Sscsrind`` Supported
+ ``Ssctr`` Assembly Support
``Ssdbltrp`` Supported
``Ssnpm`` Supported
``Sspm`` Supported
@@ -337,12 +341,6 @@ The primary goal of experimental support is to assist in the process of ratifica
``experimental-zvbc32e``, ``experimental-zvkgs``
LLVM implements the `0.7 release specification <https://github.com/user-attachments/files/16450464/riscv-crypto-spec-vector-extra_v0.0.7.pdf>`__.
-``experimental-sdext``, ``experimental-sdtrig``
- LLVM implements the `1.0-rc4 specification <https://github.com/riscv/riscv-debug-spec/releases/download/1.0.0-rc4/riscv-debug-specification.pdf>`__.
-
-``experimental-smctr``, ``experimental-ssctr``
- LLVM implements the `1.0-rc3 specification <https://github.com/riscv/riscv-control-transfer-records/releases/tag/v1.0_rc3>`__.
-
``experimental-svukte``
LLVM implements the `0.3 draft specification <https://github.com/riscv/riscv-isa-manual/pull/1564>`__.
|
Can we also give these extensions a |
They have assembly instructions, and are outside the scope of the riscv profile. Do we need to add the spec document to RISCVUsage.rst? |
Yes, adding a |
Add Smctr, Ssctr,Sdext and Sdtrig spec docs. We can list the specs of other extensions, if needed. |
llvm/docs/RISCVUsage.rst
Outdated
.. _riscv-extensions-specifications-note: | ||
|
||
``Sdext``, ``Sdtrig`` `The RISC-V Debug Specification <https://github.com/riscv/riscv-debug-spec/releases/download/1.0/riscv-debug-specification.pdf>`__. | ||
``Smctr``, ``Ssctr`` `RISC-V Control Transfer Records <https://github.com/riscv/riscv-control-transfer-records/releases/download/v1.0_rc3/riscv-ctr-v1.0_rc3.pdf>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smctr and Ssctr have been integrated into the riscv-isa-manual I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete Smctr and Ssctr spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.