Skip to content

[mlir][dataflow] Use skipRegions to print region op (NFC) #161066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2025
+10 −8
Merged

[mlir][dataflow] Use skipRegions to print region op (NFC) #161066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b62066
Use skipRegions to print region op.
linuxlonelyeagle Sep 28, 2025
ae9271d
update
linuxlonelyeagle Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions mlir/lib/Analysis/DataFlow/LivenessAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,19 +109,19 @@ LivenessAnalysis::visitOperation(Operation *op, ArrayRef<Liveness *> operands,
foundLiveResult = true;
}
LDBG() << "[visitOperation] Adding dependency for result: " << r
<< " after op: " << *op;
<< " after op: " << OpWithFlags(op, OpPrintingFlags().skipRegions());
addDependency(const_cast<Liveness *>(r), getProgramPointAfter(op));
}
return success();
}

void LivenessAnalysis::visitBranchOperand(OpOperand &operand) {
Operation *op = operand.getOwner();
LDBG() << "Visiting branch operand: " << operand.get()
<< " in op: " << *operand.getOwner();
<< " in op: " << OpWithFlags(op, OpPrintingFlags().skipRegions());
// We know (at the moment) and assume (for the future) that `operand` is a
// non-forwarded branch operand of a `RegionBranchOpInterface`,
// `BranchOpInterface`, `RegionBranchTerminatorOpInterface` or return-like op.
Operation *op = operand.getOwner();
assert((isa<RegionBranchOpInterface>(op) || isa<BranchOpInterface>(op) ||
isa<RegionBranchTerminatorOpInterface>(op)) &&
"expected the op to be `RegionBranchOpInterface`, "
Expand All @@ -146,12 +146,13 @@ void LivenessAnalysis::visitBranchOperand(OpOperand &operand) {
// Therefore, if the result value is live, we conservatively consider the
// non-forwarded operand of the region branch operation with result may
// live and record all result.
for (Value result : op->getResults()) {
for (auto [resultIndex, result] : llvm::enumerate(op->getResults())) {
if (getLatticeElement(result)->isLive) {
mayLive = true;
LDBG() << "[visitBranchOperand] Non-forwarded branch "
"operand may be live due to live result: "
<< result;
LDBG() << "[visitBranchOperand] Non-forwarded branch operand may be "
"live due to live result #"
<< resultIndex << ": "
<< OpWithFlags(op, OpPrintingFlags().skipRegions());
break;
}
}
Expand Down Expand Up @@ -233,7 +234,8 @@ void LivenessAnalysis::visitBranchOperand(OpOperand &operand) {
SmallVector<const Liveness *, 4> resultsLiveness;
for (const Value result : op->getResults())
resultsLiveness.push_back(getLatticeElement(result));
LDBG() << "Visiting operation for non-forwarded branch operand: " << *op;
LDBG() << "Visiting operation for non-forwarded branch operand: "
<< OpWithFlags(op, OpPrintingFlags().skipRegions());
(void)visitOperation(op, operandLiveness, resultsLiveness);

// We also visit the parent op with the parent's results and this operand if
Expand Down