[InstCombine] Extend vector.reduce.add and splat transform to scalable vectors #161101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Sep 29, 2025
spaits
commented
Sep 29, 2025
| ret i32 %4 | ||
| } | ||
|
|
||
| define i64 @reduce_add_splat_to_mul_vscale_4xi64(i64 %0) { |
There was a problem hiding this comment.
Alive2 doesn't seem to like these tests: https://alive2.llvm.org/ce/z/W6Tueq .
Usually when I do a syntax or semantic error it gives error code 255 and writes the compile error. But in this case it just gives error code 1 and no output.
The function signatures match. If I remove the body of the src it gives output. It says that it doesn't know the semantics of @llvm.vscale.i64.
spaits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the conversation of @nikic and @dtcxzyw in PR #161020 .
TODO: