Skip to content

[ARM][clang] Add some build attributes support #161106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+48 −6
Open

[ARM][clang] Add some build attributes support #161106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions clang/lib/CodeGen/CodeGenModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
#include "llvm/IR/ProfileSummary.h"
#include "llvm/ProfileData/InstrProfReader.h"
#include "llvm/ProfileData/SampleProf.h"
#include "llvm/Support/ARMBuildAttributes.h"
#include "llvm/Support/CRC.h"
#include "llvm/Support/CodeGen.h"
#include "llvm/Support/CommandLine.h"
Expand Down Expand Up @@ -1383,6 +1384,32 @@ void CodeGenModule::Release() {
}
}
}
if ((T.isARM() || T.isThumb()) && getTriple().isTargetAEABI() &&
getTriple().isOSBinFormatELF()) {
uint32_t TagVal = 0;
if (getCodeGenOpts().FPDenormalMode ==
llvm::DenormalMode::getPositiveZero())
TagVal = llvm::ARMBuildAttrs::PositiveZero;
else if (getCodeGenOpts().FPDenormalMode == llvm::DenormalMode::getIEEE())
TagVal = llvm::ARMBuildAttrs::IEEEDenormals;
else if (getCodeGenOpts().FPDenormalMode ==
llvm::DenormalMode::getPreserveSign())
TagVal = llvm::ARMBuildAttrs::PreserveFPSign;
getModule().addModuleFlag(llvm::Module::Warning, "arm-eabi-fp-denormal",
TagVal);

if (getLangOpts().getFPExceptionMode() !=
LangOptions::FPExceptionModeKind::FPE_Ignore)
getModule().addModuleFlag(llvm::Module::Warning, "arm-eabi-fp-exceptions",
llvm::ARMBuildAttrs::Allowed);

if (getLangOpts().NoHonorNaNs && getLangOpts().NoHonorInfs)
TagVal = llvm::ARMBuildAttrs::AllowIEEENormal;
else
TagVal = llvm::ARMBuildAttrs::AllowIEEE754;
getModule().addModuleFlag(llvm::Module::Warning, "arm-eabi-fp-number-model",
TagVal);
}

if (CodeGenOpts.StackClashProtector)
getModule().addModuleFlag(
Expand Down
15 changes: 15 additions & 0 deletions clang/test/CodeGen/ARM/build-attributes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// RUN: %clang_cc1 -triple arm-none-eabi -fdenormal-fp-math=positive-zero -emit-llvm -o - | FileCheck %s --check-prefix=DM-PZ
// RUN: %clang_cc1 -triple arm-none-eabi -fdenormal-fp-math=ieee -emit-llvm -o - | FileCheck %s --check-prefix=DM-IEEE
// RUN: %clang_cc1 -triple arm-none-eabi -fdenormal-fp-math=preserve-sign -emit-llvm -o - | FileCheck %s --check-prefix=DM-PS

// RUN: %clang_cc1 -triple arm-none-eabi -menable-no-infs -menable-no-nans -emit-llvm -o - | FileCheck %s --check-prefix=NM-FIN
// RUN: %clang_cc1 -triple arm-none-eabi -emit-llvm -o - | FileCheck %s --check-prefix=NM-IEEE

// DM-PZ: !{i32 2, !"arm-eabi-fp-denormal", i32 0}
// DM-IEEE: !{i32 2, !"arm-eabi-fp-denormal", i32 1}
// DM-PS: !{i32 2, !"arm-eabi-fp-denormal", i32 2}

// NM-FIN: !{i32 2, !"arm-eabi-fp-number-model", i32 1}
// NM-IEEE: !{i32 2, !"arm-eabi-fp-number-model", i32 3}

void foo() {}
6 changes: 3 additions & 3 deletions clang/test/CodeGen/ubsan-function-sugared.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ auto fun() {}

// GNU-LABEL: define{{.*}} void @_Z6callerv()
// MSVC-LABEL: define{{.*}} void @"?caller@@YAXXZ"()
// ARM: ptrtoint ptr {{.*}} to i32, !nosanitize !4
// ARM: and i32 {{.*}}, -2, !nosanitize !4
// ARM: inttoptr i32 {{.*}} to ptr, !nosanitize !4
// ARM: ptrtoint ptr {{.*}} to i32, !nosanitize !7
// ARM: and i32 {{.*}}, -2, !nosanitize !7
// ARM: inttoptr i32 {{.*}} to ptr, !nosanitize !7
// CHECK: getelementptr <{ i32, i32 }>, ptr {{.*}}, i32 -1, i32 0, !nosanitize
// CHECK: load i32, ptr {{.*}}, align {{.*}}, !nosanitize
// CHECK: icmp eq i32 {{.*}}, -1056584962, !nosanitize
Expand Down
6 changes: 3 additions & 3 deletions clang/test/CodeGen/ubsan-function.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ void fun() {}

// GNU-LABEL: define{{.*}} void @_Z6callerPFvvE(ptr noundef %f)
// MSVC-LABEL: define{{.*}} void @"?caller@@YAXP6AXXZ@Z"(ptr noundef %f)
// ARM: ptrtoint ptr {{.*}} to i32, !nosanitize !5
// ARM: and i32 {{.*}}, -2, !nosanitize !5
// ARM: inttoptr i32 {{.*}} to ptr, !nosanitize !5
// ARM: ptrtoint ptr {{.*}} to i32, !nosanitize !8
// ARM: and i32 {{.*}}, -2, !nosanitize !8
// ARM: inttoptr i32 {{.*}} to ptr, !nosanitize !8
// AUTH: %[[STRIPPED:.*]] = ptrtoint ptr {{.*}} to i64, !nosanitize
// AUTH: call i64 @llvm.ptrauth.auth(i64 %[[STRIPPED]], i32 0, i64 0), !nosanitize
// CHECK: getelementptr <{ i32, i32 }>, ptr {{.*}}, i32 -1, i32 0, !nosanitize
Expand Down