[CodeGen] Fix performance regression introduced in b05101b #161313
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.8-beta.1
arichardson
commented
Sep 30, 2025
| let isNormalValueType = false in { | ||
| // Pseudo valuetype mapped to the current CHERI capability pointer size. | ||
| // Should only be used in TableGen. | ||
| def cPTR : VTAny<503>; |
There was a problem hiding this comment.
Unrelated to this change but I wonder if we should we also renumber the other values and move this next to iPTR?
arichardson
deleted the
users/arichardson/spr/codegen-fix-performance-regression-introduced-in-b05101b
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 30, 2025
The isNormalValueType = false flag was not set for this pseudo value type, which caused significant size increases for some classes: the size of the TargetLoweringBase class to 1.5 MB, because the size of that class is quadratic in MVT::VALUETYPE_SIZE, and this commit increased that from 256 to 504. Reported by: abadams Fixes: b05101b ("[TableGen, CodeGen, CHERI] Add support for the cPTR wildcard value type.") Reviewed By: nikic Pull Request: llvm/llvm-project#161313
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
The isNormalValueType = false flag was not set for this pseudo value type, which caused significant size increases for some classes: the size of the TargetLoweringBase class to 1.5 MB, because the size of that class is quadratic in MVT::VALUETYPE_SIZE, and this commit increased that from 256 to 504. Reported by: abadams Fixes: b05101b ("[TableGen, CodeGen, CHERI] Add support for the cPTR wildcard value type.") Reviewed By: nikic Pull Request: llvm#161313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isNormalValueType = false flag was not set for this pseudo value
type, which caused significant size increases for some classes: the
size of the TargetLoweringBase class to 1.5 MB, because the size of
that class is quadratic in MVT::VALUETYPE_SIZE, and this commit
increased that from 256 to 504.
Reported by: abadams
Fixes: b05101b ("[TableGen, CodeGen, CHERI] Add support for the cPTR wildcard value type.")